Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14036173
D11778.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D11778.diff
View Options
diff --git a/src/applications/conpherence/controller/ConpherenceNewController.php b/src/applications/conpherence/controller/ConpherenceNewController.php
--- a/src/applications/conpherence/controller/ConpherenceNewController.php
+++ b/src/applications/conpherence/controller/ConpherenceNewController.php
@@ -12,6 +12,7 @@
$message = '';
$e_participants = null;
$e_message = null;
+ $errors = array();
// this comes from ajax requests from all over. should be a single phid.
@@ -29,10 +30,15 @@
foreach ($error_codes as $error_code) {
switch ($error_code) {
case ConpherenceEditor::ERROR_EMPTY_MESSAGE:
- $e_message = true;
+ $e_message = pht('Required');
+ $errors[] = pht(
+ 'You can not send an empty message.');
break;
case ConpherenceEditor::ERROR_EMPTY_PARTICIPANTS:
- $e_participants = true;
+ $e_participants = pht('Required');
+ $errors[] = pht(
+ 'You must choose at least one recipient for your '.
+ 'message.');
break;
}
}
@@ -69,6 +75,7 @@
$dialog = id(new AphrontDialogView())
->setWidth(AphrontDialogView::WIDTH_FORM)
+ ->setErrors($errors)
->setUser($user)
->setTitle($title)
->addCancelButton($cancel_uri)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Nov 11, 8:53 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6740068
Default Alt Text
D11778.diff (1 KB)
Attached To
Mode
D11778: Improve error messaging for empty Conpherence threads
Attached
Detach File
Event Timeline
Log In to Comment