Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14034242
D12076.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D12076.id.diff
View Options
diff --git a/src/applications/files/conduit/FileAllocateConduitAPIMethod.php b/src/applications/files/conduit/FileAllocateConduitAPIMethod.php
--- a/src/applications/files/conduit/FileAllocateConduitAPIMethod.php
+++ b/src/applications/files/conduit/FileAllocateConduitAPIMethod.php
@@ -17,9 +17,6 @@
'contentLength' => 'int',
'contentHash' => 'optional string',
'viewPolicy' => 'optional string',
-
- // TODO: Remove this, it's just here to make testing easier.
- 'forceChunking' => 'optional bool',
);
}
@@ -39,8 +36,6 @@
$view_policy = $request->getValue('viewPolicy');
$length = $request->getValue('contentLength');
- $force_chunking = $request->getValue('forceChunking');
-
$properties = array(
'name' => $name,
'authorPHID' => $viewer->getPHID(),
@@ -93,14 +88,6 @@
$engines = PhabricatorFileStorageEngine::loadStorageEngines($length);
if ($engines) {
- if ($force_chunking) {
- foreach ($engines as $key => $engine) {
- if (!$engine->isChunkEngine()) {
- unset($engines[$key]);
- }
- }
- }
-
// Pick the first engine. If the file is small enough to fit into a
// single engine without chunking, this will be a non-chunk engine and
// we'll just tell the client to upload the file.
diff --git a/src/applications/files/controller/PhabricatorFileDropUploadController.php b/src/applications/files/controller/PhabricatorFileDropUploadController.php
--- a/src/applications/files/controller/PhabricatorFileDropUploadController.php
+++ b/src/applications/files/controller/PhabricatorFileDropUploadController.php
@@ -42,9 +42,6 @@
'name' => $name,
'contentLength' => $request->getInt('length'),
'viewPolicy' => $view_policy,
-
- // TODO: Remove.
- // 'forceChunking' => true,
);
$result = id(new ConduitCall('file.allocate', $params))
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 10, 11:10 PM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6734781
Default Alt Text
D12076.id.diff (1 KB)
Attached To
Mode
D12076: Delete all "force chunking" file upload code
Attached
Detach File
Event Timeline
Log In to Comment