Page MenuHomePhabricator
Files F14031685

D15568.id.diff
No OneTemporary
Actions

D15568.id.diff
View Options

diff --git a/src/applications/macro/controller/PhabricatorMacroEditController.php b/src/applications/macro/controller/PhabricatorMacroEditController.php
--- a/src/applications/macro/controller/PhabricatorMacroEditController.php
+++ b/src/applications/macro/controller/PhabricatorMacroEditController.php
@@ -233,16 +233,19 @@
$crumbs = $this->buildApplicationCrumbs();
if ($macro->getID()) {
- $title = pht('Edit Image Macro');
+ $title = pht('Edit Macro: %s', $macro->getName());
$crumb = pht('Edit Macro');
+ $header_icon = 'fa-pencil';
- $crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
+ $crumbs->addTextCrumb(pht('Macro: %s', $macro->getName()), $view_uri);
} else {
$title = pht('Create Image Macro');
$crumb = pht('Create Macro');
+ $header_icon = 'fa-plus-square';
}
$crumbs->addTextCrumb($crumb, $request->getRequestURI());
+ $crumbs->setBorder(true);
$upload = null;
if ($macro->getID()) {
@@ -267,23 +270,32 @@
$upload = id(new PHUIObjectBoxView())
->setHeaderText(pht('Upload New File'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($upload_form);
}
$form_box = id(new PHUIObjectBoxView())
- ->setHeaderText($title)
+ ->setHeaderText(pht('Macro'))
->setFormErrors($errors)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($form);
- return $this->buildApplicationPage(
- array(
- $crumbs,
+ $header = id(new PHUIHeaderView())
+ ->setHeader($title)
+ ->setHeaderIcon($header_icon);
+
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setFooter(array(
$form_box,
$upload,
- ),
- array(
- 'title' => $title,
));
+
+ return $this->newPage()
+ ->setTitle($title)
+ ->setCrumbs($crumbs)
+ ->appendChild($view);
+
}
}

File Metadata

Mime Type
text/plain
Expires
Sun, Nov 10, 11:44 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6737037
Default Alt Text
D15568.id.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility