Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14029891
D15886.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D15886.diff
View Options
diff --git a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
--- a/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+++ b/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
@@ -310,6 +310,10 @@
'notification.enabled' => $aphlict_reason,
'notification.client-uri' => $aphlict_reason,
'notification.server-uri' => $aphlict_reason,
+
+ 'metamta.differential.unified-comment-context' => pht(
+ 'Inline comments are now always rendered with a limited amount '.
+ 'of context.'),
);
return $ancient_config;
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -287,21 +287,6 @@
'unified')
->setDescription(
pht("Format for inlined or attached patches: 'git' or 'unified'.")),
- $this->newOption(
- 'metamta.differential.unified-comment-context',
- 'bool',
- false)
- ->setBoolOptions(
- array(
- pht('Show context'),
- pht('Do not show context'),
- ))
- ->setSummary(pht('Show diff context around inline comments in email.'))
- ->setDescription(
- pht(
- 'Normally, inline comments in emails are shown with a file and '.
- 'line but without any diff context. Enabling this option adds '.
- 'diff context and the comment thread.')),
);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 9, 10:26 PM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6737116
Default Alt Text
D15886.diff (1 KB)
Attached To
Mode
D15886: Remove `metamta.differential.unified-comment-context` and explain it in ExtraConfigSetupCheck
Attached
Detach File
Event Timeline
Log In to Comment