Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14026555
D14423.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D14423.diff
View Options
diff --git a/externals/skins/oblivious/header.php b/externals/skins/oblivious/header.php
--- a/externals/skins/oblivious/header.php
+++ b/externals/skins/oblivious/header.php
@@ -13,6 +13,6 @@
echo _e($blog->getName());
?></a>
</h1>
- <p><?php echo _e($blog->getDescription()); ?></p>
+ <p><?php echo $skin->remarkup($blog->getDescription()); ?></p>
</div>
<div class="oblivious-content">
diff --git a/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php b/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
--- a/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
+++ b/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
@@ -79,6 +79,12 @@
return $this->cssResources;
}
+ public function remarkup($corpus) {
+ $view = id(new PHUIRemarkupView($this->getViewer(), $corpus));
+
+ return hsprintf('%s', $view);
+ }
+
public function getName() {
return $this->getSpecification()->getName();
}
@@ -107,13 +113,16 @@
private function getDefaultScope() {
return array(
- 'skin' => $this,
- 'blog' => $this->getBlog(),
- 'uri' => $this->getURI($this->getURIPath()),
- 'home_uri' => $this->getURI(''),
- 'title' => $this->getTitle(),
+ 'skin' => $this,
+ 'blog' => $this->getBlog(),
+ 'uri' => $this->getURI($this->getURIPath()),
+ 'home_uri' => $this->getURI(''),
+
+ // TODO: This is wrong for detail pages, which should show the post
+ // title, but getting it right is a pain and this is better than nothing.
+ 'title' => $this->getBlog()->getName(),
'description' => $this->getDescription(),
- 'og_type' => $this->getOGType(),
+ 'og_type' => $this->getOGType(),
);
}
@@ -135,7 +144,7 @@
return $this->renderTemplate(
'post-detail.php',
array(
- 'post' => $post,
+ 'post' => $post,
));
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 9, 1:39 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6729563
Default Alt Text
D14423.diff (1 KB)
Attached To
Mode
D14423: Fix Oblivious skin summary remarkup and partially fix title
Attached
Detach File
Event Timeline
Log In to Comment