Page MenuHomePhabricator

D10550.diff
No OneTemporary

D10550.diff

diff --git a/src/applications/releeph/application/PhabricatorReleephApplication.php b/src/applications/releeph/application/PhabricatorReleephApplication.php
--- a/src/applications/releeph/application/PhabricatorReleephApplication.php
+++ b/src/applications/releeph/application/PhabricatorReleephApplication.php
@@ -18,11 +18,8 @@
return 'releeph';
}
- public function isInstalled() {
- if (PhabricatorEnv::getEnvConfig('releeph.installed')) {
- return parent::isInstalled();
- }
- return false;
+ public function isPrototype() {
+ return true;
}
public function getRoutes() {
diff --git a/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php b/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php
--- a/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php
+++ b/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php
@@ -42,19 +42,6 @@
$custom_field_type = 'custom:PhabricatorCustomFieldConfigOptionType';
return array(
- $this->newOption('releeph.installed', 'bool', false)
- ->setSummary(pht('Enable the Releeph application.'))
- ->setDescription(
- pht(
- 'Releeph, a tool for managing release branches, will eventually '.
- 'fit in to the Phabricator suite as a general purpose tool. '.
- 'However Releeph is currently unstable in multiple ways that may '.
- 'not migrate properly for you: the code is still in alpha stage '.
- 'of design, the storage format is likely to change in unexpected '.
- 'ways, and the workflows presented are very specific to a core '.
- 'set of alpha testers at Facebook. For the time being you are '.
- 'strongly discouraged from relying on Releeph being at all '.
- 'stable.')),
$this->newOption('releeph.fields', $custom_field_type, $default)
->setCustomData('ReleephFieldSpecification'),
$this->newOption(
diff --git a/src/infrastructure/testing/PhabricatorTestCase.php b/src/infrastructure/testing/PhabricatorTestCase.php
--- a/src/infrastructure/testing/PhabricatorTestCase.php
+++ b/src/infrastructure/testing/PhabricatorTestCase.php
@@ -116,9 +116,6 @@
'notification.enabled',
false);
- // TODO: Remove this when we remove "releeph.installed".
- $this->env->overrideEnvConfig('releeph.installed', true);
-
$this->env->overrideEnvConfig(
'phabricator.base-uri',
'http://phabricator.example.com');

File Metadata

Mime Type
text/plain
Expires
Fri, Nov 8, 8:23 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6736604
Default Alt Text
D10550.diff (2 KB)

Event Timeline