Page MenuHomePhabricator
Files F14023989

D9257.diff
No OneTemporary
Actions

D9257.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2490,7 +2490,6 @@
'PhragmentUpdateController' => 'applications/phragment/controller/PhragmentUpdateController.php',
'PhragmentVersionController' => 'applications/phragment/controller/PhragmentVersionController.php',
'PhragmentZIPController' => 'applications/phragment/controller/PhragmentZIPController.php',
- 'PhrequentConduitAPIQueryTestCase' => 'applications/phrequent/conduit/__tests__/PhrequentConduitAPIQueryTestCase.php',
'PhrequentController' => 'applications/phrequent/controller/PhrequentController.php',
'PhrequentDAO' => 'applications/phrequent/storage/PhrequentDAO.php',
'PhrequentListController' => 'applications/phrequent/controller/PhrequentListController.php',
@@ -5394,7 +5393,6 @@
'PhragmentUpdateController' => 'PhragmentController',
'PhragmentVersionController' => 'PhragmentController',
'PhragmentZIPController' => 'PhragmentController',
- 'PhrequentConduitAPIQueryTestCase' => 'PhabricatorTestCase',
'PhrequentController' => 'PhabricatorController',
'PhrequentDAO' => 'PhabricatorLiskDAO',
'PhrequentListController' => 'PhrequentController',
diff --git a/src/applications/phrequent/conduit/ConduitAPI_phrequent_Method.php b/src/applications/phrequent/conduit/ConduitAPI_phrequent_Method.php
--- a/src/applications/phrequent/conduit/ConduitAPI_phrequent_Method.php
+++ b/src/applications/phrequent/conduit/ConduitAPI_phrequent_Method.php
@@ -7,7 +7,8 @@
abstract class ConduitAPI_phrequent_Method extends ConduitAPIMethod {
public function getApplication() {
- return PhabricatorApplication::getByClass('PhabricatorApplicationPhrequent');
+ return
+ PhabricatorApplication::getByClass('PhabricatorApplicationPhrequent');
}
public function getMethodStatus() {
@@ -15,7 +16,8 @@
}
public function getMethodStatusDescription() {
- return pht('Phrequent is still in beta. The Conduit API was recently added and still under development.');
+ return pht('Phrequent is still in beta.
+ The Conduit API was recently added and still under development.');
}
protected function buildBlockDictionary(array $blocks) {
diff --git a/src/applications/phrequent/conduit/ConduitAPI_phrequent_query_Method.php b/src/applications/phrequent/conduit/ConduitAPI_phrequent_query_Method.php
--- a/src/applications/phrequent/conduit/ConduitAPI_phrequent_query_Method.php
+++ b/src/applications/phrequent/conduit/ConduitAPI_phrequent_query_Method.php
@@ -4,21 +4,24 @@
* @group conduit
*/
-final class ConduitAPI_phrequent_query_Method extends ConduitAPI_phrequent_Method {
+final class ConduitAPI_phrequent_query_Method
+ extends ConduitAPI_phrequent_Method {
public function getMethodDescription() {
return pht('Run searches for Phrequent time trackers.');
}
public function defineParamTypes() {
- $endedOptions = $this->formatStringConstants(PhrequentUserTimeQuery::getEndedSearchOptions());
- $orderOptions = $this->formatStringConstants(PhrequentUserTimeQuery::getOrderSearchOptions());
+ $ended_options = $this->formatStringConstants(
+ PhrequentUserTimeQuery::getEndedSearchOptions());
+ $order_options = $this->formatStringConstants(
+ PhrequentUserTimeQuery::getOrderSearchOptions());
return array(
- 'userPHIDs' => 'optional list<phid>',
- 'objectPHIDs' => 'optional list<phid>',
- 'ended' => 'optional '.$endedOptions,
- 'order' => 'optional '.$orderOptions);
+ 'userPHIDs' => 'optional list<phid>',
+ 'objectPHIDs' => 'optional list<phid>',
+ 'ended' => 'optional '.$ended_options,
+ 'order' => 'optional '.$order_options);
}
public function defineReturnType() {
@@ -36,11 +39,11 @@
$users = $request->getValue('userPHIDs');
$objects = $request->getValue('objectPHIDs');
- $endedOptions = $query->getEndedSearchOptions();
- $ended = array_search($request->getValue('ended'), $endedOptions);
+ $ended_options = $query->getEndedSearchOptions();
+ $ended = array_search($request->getValue('ended'), $ended_options);
- $orderOptions = $query->getorderSearchOptions();
- $order = array_search($request->getValue('order'), $orderOptions);
+ $order_options = $query->getorderSearchOptions();
+ $order = array_search($request->getValue('order'), $order_options);
if ($users) {
$query->withUserPHIDs($users);

File Metadata

Mime Type
text/plain
Expires
Fri, Nov 8, 4:43 AM (14 h, 7 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6732967
Default Alt Text
D9257.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility