Page MenuHomePhabricator
Files F14022145

D13770.diff
No OneTemporary
Actions

D13770.diff
View Options

diff --git a/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php b/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php
--- a/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php
+++ b/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php
@@ -3,22 +3,16 @@
final class PhabricatorXHProfProfileController
extends PhabricatorXHProfController {
- private $phid;
-
public function shouldAllowPublic() {
return true;
}
- public function willProcessRequest(array $data) {
- $this->phid = $data['phid'];
- }
-
- public function processRequest() {
- $request = $this->getRequest();
+ public function handleRequest(AphrontRequest $request) {
+ $phid = $request->getURIData('phid');
$file = id(new PhabricatorFileQuery())
->setViewer($request->getUser())
- ->withPHIDs(array($this->phid))
+ ->withPHIDs(array($phid))
->executeOne();
if (!$file) {
return new Aphront404Response();
diff --git a/src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php b/src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
--- a/src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
+++ b/src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
@@ -3,24 +3,22 @@
final class PhabricatorXHProfSampleListController
extends PhabricatorXHProfController {
- private $view;
-
public function shouldAllowPublic() {
return true;
}
- public function willProcessRequest(array $data) {
- $this->view = idx($data, 'view', 'all');
- }
+ public function handleRequest(AphrontRequest $request) {
+ $viewer = $request->getViewer();
+ $view = $request->getURIData('view');
- public function processRequest() {
- $request = $this->getRequest();
- $user = $request->getUser();
+ if (!$view) {
+ $view = 'all';
+ }
$pager = new PHUIPagerView();
$pager->setOffset($request->getInt('page'));
- switch ($this->view) {
+ switch ($view) {
case 'sampled':
$clause = 'sampleRate > 0';
$show_type = false;
@@ -78,7 +76,7 @@
$item->addIcon(
'none',
- phabricator_datetime($sample->getDateCreated(), $user));
+ phabricator_datetime($sample->getDateCreated(), $viewer));
$list->addItem($item);
}

File Metadata

Mime Type
text/plain
Expires
Thu, Nov 7, 3:38 PM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6717888
Default Alt Text
D13770.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility