Page MenuHomePhabricator
Files F14021483

D11740.id29551.diff
No OneTemporary
Actions

D11740.id29551.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -211,7 +211,6 @@
'ArcanistXMLLinterTestCase' => 'lint/linter/__tests__/ArcanistXMLLinterTestCase.php',
'ArcanistXUnitTestResultParser' => 'unit/parser/ArcanistXUnitTestResultParser.php',
'CSharpToolsTestEngine' => 'unit/engine/CSharpToolsTestEngine.php',
- 'ComprehensiveLintEngine' => 'lint/engine/ComprehensiveLintEngine.php',
'NoseTestEngine' => 'unit/engine/NoseTestEngine.php',
'PhpunitTestEngine' => 'unit/engine/PhpunitTestEngine.php',
'PhpunitTestEngineTestCase' => 'unit/engine/__tests__/PhpunitTestEngineTestCase.php',
@@ -390,7 +389,6 @@
'ArcanistXMLLinter' => 'ArcanistLinter',
'ArcanistXMLLinterTestCase' => 'ArcanistLinterTestCase',
'CSharpToolsTestEngine' => 'XUnitTestEngine',
- 'ComprehensiveLintEngine' => 'ArcanistComprehensiveLintEngine',
'NoseTestEngine' => 'ArcanistUnitTestEngine',
'PhpunitTestEngine' => 'ArcanistUnitTestEngine',
'PhpunitTestEngineTestCase' => 'ArcanistTestCase',
diff --git a/src/lint/engine/ArcanistComprehensiveLintEngine.php b/src/lint/engine/ArcanistComprehensiveLintEngine.php
--- a/src/lint/engine/ArcanistComprehensiveLintEngine.php
+++ b/src/lint/engine/ArcanistComprehensiveLintEngine.php
@@ -2,10 +2,8 @@
/**
* Basic lint engine which just applies several linters based on the file types.
- *
- * @todo Should be final but isn't because of @{class:ComprehensiveLintEngine}.
*/
-class ArcanistComprehensiveLintEngine extends ArcanistLintEngine {
+final class ArcanistComprehensiveLintEngine extends ArcanistLintEngine {
public function buildLinters() {
$linters = array();
diff --git a/src/lint/engine/ComprehensiveLintEngine.php b/src/lint/engine/ComprehensiveLintEngine.php
deleted file mode 100644
--- a/src/lint/engine/ComprehensiveLintEngine.php
+++ /dev/null
@@ -1,15 +0,0 @@
-<?php
-
-/**
- * @deprecated
- */
-final class ComprehensiveLintEngine extends ArcanistComprehensiveLintEngine {
-
- public function buildLinters() {
- phutil_deprecated(
- __CLASS__,
- 'You should use `ArcanistComprehensiveLintEngine` instead.');
- parent::buildLinters();
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Thu, Nov 7, 9:16 AM (5 d, 17 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6728555
Default Alt Text
D11740.id29551.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility