D17885.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D17885.diff
View Options

	diff --git a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
	--- a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
	+++ b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
	@@ -6,16 +6,14 @@
	const TRANSACTIONTYPE = 'points';

	public function generateOldValue($object) {
	- return $object->getPoints();
	+ return $this->getValueForPoints($object->getPoints());
	+ }
	+
	+ public function generateNewValue($object, $value) {
	+ return $this->getValueForPoints($value);
	}

	public function applyInternalEffects($object, $value) {
	- if (!strlen($value)) {
	- $value = null;
	- }
	- if ($value !== null) {
	- $value = (double)$value;
	- }
	$object->setPoints($value);
	}

	@@ -73,4 +71,14 @@
	return $errors;
	}

	+ private function getValueForPoints($value) {
	+ if (!strlen($value)) {
	+ $value = null;
	+ }
	+ if ($value !== null) {
	+ $value = (double)$value;
	+ }
	+ return $value;
	+ }
	+
	}