Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14017183
D19416.id46450.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
918 B
Referenced Files
None
Subscribers
None
D19416.id46450.diff
View Options
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -153,9 +153,17 @@
$request_uri = $request->getRequestURI();
+ // Revisions with more than 100 files are "large".
+ // Revisions with more than 1000 files are "very large".
$limit = 100;
$large = $request->getStr('large');
- if (count($changesets) > $limit && !$large) {
+
+ $large_warning =
+ (!$this->isVeryLargeDiff()) &&
+ (count($changesets) > $limit) &&
+ (!$large);
+
+ if ($large_warning) {
$count = count($changesets);
$warning = new PHUIInfoView();
$warning->setTitle(pht('Large Diff'));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 5, 2:30 PM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6757217
Default Alt Text
D19416.id46450.diff (918 B)
Attached To
Mode
D19416: Hide the "large" diff warning on "very large" diffs
Attached
Detach File
Event Timeline
Log In to Comment