Page MenuHomePhabricator
Files F14014937

D7767.diff
No OneTemporary
Actions

D7767.diff
View Options

Index: src/applications/phragment/controller/PhragmentVersionController.php
===================================================================
--- src/applications/phragment/controller/PhragmentVersionController.php
+++ src/applications/phragment/controller/PhragmentVersionController.php
@@ -84,60 +84,12 @@
$crumbs,
$this->renderConfigurationWarningIfRequired(),
$box,
- $this->renderPatchFromPreviousVersion($version, $file),
$this->renderPreviousVersionList($version)),
array(
'title' => pht('View Version'),
'device' => true));
}
- private function renderPatchFromPreviousVersion(
- PhragmentFragmentVersion $version,
- PhabricatorFile $file) {
-
- $request = $this->getRequest();
- $viewer = $request->getUser();
-
- $previous_file = null;
- $previous = id(new PhragmentFragmentVersionQuery())
- ->setViewer($viewer)
- ->withFragmentPHIDs(array($version->getFragmentPHID()))
- ->withSequences(array($version->getSequence() - 1))
- ->executeOne();
- if ($previous !== null) {
- $previous_file = id(new PhabricatorFileQuery())
- ->setViewer($viewer)
- ->withPHIDs(array($previous->getFilePHID()))
- ->executeOne();
- }
-
- $patch = PhragmentPatchUtil::calculatePatch($previous_file, $file);
-
- if ($patch === null) {
- return id(new AphrontErrorView())
- ->setSeverity(AphrontErrorView::SEVERITY_NOTICE)
- ->setTitle(pht("Identical Version"))
- ->appendChild(phutil_tag(
- 'p',
- array(),
- pht("This version is identical to the previous version.")));
- }
-
- if (strlen($patch) > 20480) {
- // Patch is longer than 20480 characters. Trim it and let the user know.
- $patch = substr($patch, 0, 20480)."\n...\n";
- $patch .= pht(
- "This patch is longer than 20480 characters. Use the link ".
- "in the action list to download the full patch.");
- }
-
- return id(new PHUIObjectBoxView())
- ->setHeader(id(new PHUIHeaderView())
- ->setHeader(pht('Differences since previous version')))
- ->appendChild(id(new PhabricatorSourceCodeView())
- ->setLines(phutil_split_lines($patch)));
- }
-
private function renderPreviousVersionList(
PhragmentFragmentVersion $version) {

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 4, 10:29 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6717107
Default Alt Text
D7767.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility