Page MenuHomePhabricator
Files F14007581

D8821.diff
No OneTemporary
Actions

D8821.diff
View Options

diff --git a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
--- a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
+++ b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
@@ -55,6 +55,7 @@
// Not as customizable as a ReleephRequest's commit message. It doesn't
// really need to be.
+ // TODO: Yes it does, see FB-specific stuff below.
$commit_message = array();
$commit_message[] = $h_branch->getFullName();
$commit_message[] = $h_branch->getURI();
@@ -84,7 +85,7 @@
* @new-branch: <branch-name>
*
*/
- $repo = $project->loadPhabricatorRepository();
+ $repo = $project->getRepository();
switch ($repo->getVersionControlSystem()) {
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
$commit_message[] = sprintf(
diff --git a/src/applications/releeph/controller/request/ReleephRequestEditController.php b/src/applications/releeph/controller/request/ReleephRequestEditController.php
--- a/src/applications/releeph/controller/request/ReleephRequestEditController.php
+++ b/src/applications/releeph/controller/request/ReleephRequestEditController.php
@@ -252,7 +252,7 @@
->setValue($title));
} else {
$origin = $branch->getURI();
- $repo = $product->loadPhabricatorRepository();
+ $repo = $product->getRepository();
$branch_cut_point = id(new PhabricatorRepositoryCommit())
->loadOneWhere(
'phid = %s',
diff --git a/src/applications/releeph/storage/ReleephProject.php b/src/applications/releeph/storage/ReleephProject.php
--- a/src/applications/releeph/storage/ReleephProject.php
+++ b/src/applications/releeph/storage/ReleephProject.php
@@ -95,14 +95,6 @@
return $this->assertAttached($this->repository);
}
- // TODO: Remove once everything uses ProjectQuery. Also, T603.
- public function loadPhabricatorRepository() {
- return $this->loadOneRelative(
- new PhabricatorRepository(),
- 'phid',
- 'getRepositoryPHID');
- }
-
public function getReleephFieldSelector() {
return new ReleephDefaultFieldSelector();
}

File Metadata

Mime Type
text/plain
Expires
Wed, Oct 30, 8:23 AM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6718268
Default Alt Text
D8821.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility