Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14004953
D8370.id19894.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
4 KB
Referenced Files
None
Subscribers
None
D8370.id19894.diff
View Options
Index: resources/celerity/map.php
===================================================================
--- resources/celerity/map.php
+++ resources/celerity/map.php
@@ -10,7 +10,7 @@
'core.pkg.css' => 'f12d87a6',
'core.pkg.js' => 'b7bdab05',
'darkconsole.pkg.js' => 'ca8671ce',
- 'differential.pkg.css' => '5db87a66',
+ 'differential.pkg.css' => 'd1b3a605',
'differential.pkg.js' => 'e0d3b0da',
'diffusion.pkg.css' => '3783278d',
'diffusion.pkg.js' => '5b4010f4',
@@ -55,7 +55,7 @@
'rsrc/css/application/countdown/timer.css' => '86b7b0a0',
'rsrc/css/application/diff/inline-comment-summary.css' => '14a91639',
'rsrc/css/application/differential/add-comment.css' => 'c478bcaa',
- 'rsrc/css/application/differential/changeset-view.css' => '82431767',
+ 'rsrc/css/application/differential/changeset-view.css' => 'e710a360',
'rsrc/css/application/differential/core.css' => '7ac3cabc',
'rsrc/css/application/differential/local-commits-view.css' => '19649019',
'rsrc/css/application/differential/results-table.css' => '239924f9',
@@ -503,7 +503,7 @@
'conpherence-notification-css' => '403cf598',
'conpherence-update-css' => '1099a660',
'conpherence-widget-pane-css' => '87b12e0c',
- 'differential-changeset-view-css' => '82431767',
+ 'differential-changeset-view-css' => 'e710a360',
'differential-core-view-css' => '7ac3cabc',
'differential-inline-comment-editor' => 'f2441746',
'differential-local-commits-view-css' => '19649019',
Index: src/applications/differential/view/DifferentialInlineCommentEditView.php
===================================================================
--- src/applications/differential/view/DifferentialInlineCommentEditView.php
+++ src/applications/differential/view/DifferentialInlineCommentEditView.php
@@ -95,7 +95,7 @@
private function renderBody() {
$buttons = array();
- $buttons[] = phutil_tag('button', array(), 'Ready');
+ $buttons[] = phutil_tag('button', array(), pht('Ready'));
$buttons[] = javelin_tag(
'button',
array(
Index: src/infrastructure/diff/PhabricatorInlineCommentController.php
===================================================================
--- src/infrastructure/diff/PhabricatorInlineCommentController.php
+++ src/infrastructure/diff/PhabricatorInlineCommentController.php
@@ -72,14 +72,14 @@
$dialog->setUser($user);
$dialog->setSubmitURI($request->getRequestURI());
- $dialog->setTitle('Really delete this comment?');
+ $dialog->setTitle(pht('Really delete this comment?'));
$dialog->addHiddenInput('id', $this->getCommentID());
$dialog->addHiddenInput('op', 'delete');
$dialog->appendChild(
phutil_tag('p', array(), pht('Delete this inline comment?')));
$dialog->addCancelButton('#');
- $dialog->addSubmitButton('Delete');
+ $dialog->addSubmitButton(pht('Delete'));
return id(new AphrontDialogResponse())->setDialog($dialog);
case 'edit':
@@ -101,7 +101,7 @@
}
$edit_dialog = $this->buildEditDialog();
- $edit_dialog->setTitle('Edit Inline Comment');
+ $edit_dialog->setTitle(pht('Edit Inline Comment'));
$edit_dialog->addHiddenInput('id', $this->getCommentID());
$edit_dialog->addHiddenInput('op', 'edit');
@@ -139,13 +139,13 @@
if ($this->getOperation() == 'reply') {
$inline = $this->loadComment($this->getCommentID());
- $edit_dialog->setTitle('Reply to Inline Comment');
+ $edit_dialog->setTitle(pht('Reply to Inline Comment'));
$changeset = $inline->getChangesetID();
$is_new = $inline->getIsNewFile();
$number = $inline->getLineNumber();
$length = $inline->getLineLength();
} else {
- $edit_dialog->setTitle('New Inline Comment');
+ $edit_dialog->setTitle(pht('New Inline Comment'));
$changeset = $this->getChangesetID();
$is_new = $this->getIsNewFile();
$number = $this->getLineNumber();
Index: webroot/rsrc/css/application/differential/changeset-view.css
===================================================================
--- webroot/rsrc/css/application/differential/changeset-view.css
+++ webroot/rsrc/css/application/differential/changeset-view.css
@@ -246,6 +246,10 @@
white-space: normal;
}
+.differential-inline-comment-edit .aphront-form-control-textarea {
+ padding: 0;
+}
+
.differential-inline-comment-unsaved-draft {
background: #f1f1f1;
border: 1px dashed {$greytext};
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Oct 28, 6:03 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6721261
Default Alt Text
D8370.id19894.diff (4 KB)
Attached To
Mode
D8370: Align textarea in diff comment
Attached
Detach File
Event Timeline
Log In to Comment