Page MenuHomePhabricator
Files F14001627

D8587.id20367.diff
No OneTemporary
Actions

D8587.id20367.diff
View Options

diff --git a/src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php b/src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php
--- a/src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php
+++ b/src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php
@@ -58,7 +58,7 @@
=> 'HarbormasterBuildableActionController',
),
'build/' => array(
- '(?:(?P<id>\d+)/)?' => 'HarbormasterBuildViewController',
+ '(?P<id>\d+)/' => 'HarbormasterBuildViewController',
'(?P<action>stop|resume|restart)/(?P<id>\d+)/(?:(?P<via>[^/]+)/)?'
=> 'HarbormasterBuildActionController',
),
diff --git a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
--- a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
@@ -28,14 +28,11 @@
->withObjectPHIDs(array($plan->getPHID()))
->execute();
- $engine = id(new PhabricatorMarkupEngine())
- ->setViewer($viewer);
-
$xaction_view = id(new PhabricatorApplicationTransactionView())
->setUser($viewer)
->setObjectPHID($plan->getPHID())
->setTransactions($xactions)
- ->setMarkupEngine($engine);
+ ->setShouldTerminate(true);
$title = pht("Plan %d", $id);
@@ -85,6 +82,8 @@
$i = 1;
$step_list = id(new PHUIObjectItemListView())
->setUser($viewer)
+ ->setNoDataString(
+ pht('This build plan does not have any build steps yet.'))
->setID($list_id);
Javelin::initBehavior(
'harbormaster-reorder-steps',
@@ -100,7 +99,7 @@
// We can't initialize the implementation. This might be because
// it's been renamed or no longer exists.
$item = id(new PHUIObjectItemView())
- ->setObjectName("Step ".$i++)
+ ->setObjectName(pht('Step %d', $i++))
->setHeader(pht('Unknown Implementation'))
->setBarColor('red')
->addAttribute(pht(

File Metadata

Mime Type
text/plain
Expires
Sat, Oct 26, 10:25 AM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6719459
Default Alt Text
D8587.id20367.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility