Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14001223
D12005.id28901.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
10 KB
Referenced Files
None
Subscribers
None
D12005.id28901.diff
View Options
diff --git a/src/applications/almanac/controller/AlmanacController.php b/src/applications/almanac/controller/AlmanacController.php
--- a/src/applications/almanac/controller/AlmanacController.php
+++ b/src/applications/almanac/controller/AlmanacController.php
@@ -195,7 +195,7 @@
array($message, ' ', $doc_link),
));
- $box->setErrorView($error_view);
+ $box->setInfoView($error_view);
}
}
diff --git a/src/applications/auth/controller/config/PhabricatorAuthListController.php b/src/applications/auth/controller/config/PhabricatorAuthListController.php
--- a/src/applications/auth/controller/config/PhabricatorAuthListController.php
+++ b/src/applications/auth/controller/config/PhabricatorAuthListController.php
@@ -161,7 +161,7 @@
$list->setFlush(true);
$list = id(new PHUIObjectBoxView())
->setHeader($header)
- ->setErrorView($warning)
+ ->setInfoView($warning)
->appendChild($list);
return $this->buildApplicationPage(
diff --git a/src/applications/calendar/controller/PhabricatorCalendarViewController.php b/src/applications/calendar/controller/PhabricatorCalendarViewController.php
--- a/src/applications/calendar/controller/PhabricatorCalendarViewController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarViewController.php
@@ -42,7 +42,7 @@
$month_view->setUser($user);
$month_view->setHolidays($holidays);
if ($this->getNoticeView()) {
- $month_view->setErrorView($this->getNoticeView());
+ $month_view->setInfoView($this->getNoticeView());
}
$phids = mpull($statuses, 'getUserPHID');
diff --git a/src/applications/config/controller/PhabricatorConfigEditController.php b/src/applications/config/controller/PhabricatorConfigEditController.php
--- a/src/applications/config/controller/PhabricatorConfigEditController.php
+++ b/src/applications/config/controller/PhabricatorConfigEditController.php
@@ -202,7 +202,7 @@
->setForm($form);
if ($error_view) {
- $form_box->setErrorView($error_view);
+ $form_box->setInfoView($error_view);
}
$crumbs = $this->buildApplicationCrumbs();
diff --git a/src/applications/dashboard/controller/PhabricatorDashboardManageController.php b/src/applications/dashboard/controller/PhabricatorDashboardManageController.php
--- a/src/applications/dashboard/controller/PhabricatorDashboardManageController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardManageController.php
@@ -55,7 +55,7 @@
'You do not have permission to edit this dashboard. If you want to '.
'make changes, make a copy first.');
- $box->setErrorView(
+ $box->setInfoView(
id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
->setErrors(array($no_edit)));
diff --git a/src/applications/differential/controller/DifferentialDiffViewController.php b/src/applications/differential/controller/DifferentialDiffViewController.php
--- a/src/applications/differential/controller/DifferentialDiffViewController.php
+++ b/src/applications/differential/controller/DifferentialDiffViewController.php
@@ -129,7 +129,7 @@
$prop_box = id(new PHUIObjectBoxView())
->setHeader($property_head)
->addPropertyList($property_view)
- ->setErrorView($error_view);
+ ->setInfoView($error_view);
return $this->buildApplicationPage(
array(
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -261,7 +261,7 @@
$revision_warnings = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->setErrors($revision_warnings);
- $revision_detail_box->setErrorView($revision_warnings);
+ $revision_detail_box->setInfoView($revision_warnings);
}
$comment_view = $this->buildTransactions(
@@ -389,7 +389,7 @@
$review_warnings_panel = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->setErrors($review_warnings);
- $comment_form->setErrorView($review_warnings_panel);
+ $comment_form->setInfoView($review_warnings_panel);
}
$comment_form->setActions($this->getRevisionCommentActions($revision));
diff --git a/src/applications/differential/view/DifferentialAddCommentView.php b/src/applications/differential/view/DifferentialAddCommentView.php
--- a/src/applications/differential/view/DifferentialAddCommentView.php
+++ b/src/applications/differential/view/DifferentialAddCommentView.php
@@ -10,7 +10,7 @@
private $ccs = array();
private $errorView;
- public function setErrorView(PHUIInfoView $error_view) {
+ public function setInfoView(PHUIInfoView $error_view) {
$this->errorView = $error_view;
return $this;
}
@@ -188,7 +188,7 @@
->appendChild($form);
if ($this->errorView) {
- $comment_box->setErrorView($this->errorView);
+ $comment_box->setInfoView($this->errorView);
}
return array($comment_box, $preview);
diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@@ -257,7 +257,7 @@
->appendChild(
pht('This commit is very large. Load each file individually.'));
- $change_panel->setErrorView($warning_view);
+ $change_panel->setInfoView($warning_view);
$header->addActionLink($button);
}
@@ -920,7 +920,7 @@
$panel->setHeaderText(pht('Merged Changes'));
$panel->appendChild($history_table);
if ($caption) {
- $panel->setErrorView($caption);
+ $panel->setInfoView($caption);
}
return $panel;
diff --git a/src/applications/diffusion/controller/DiffusionExternalController.php b/src/applications/diffusion/controller/DiffusionExternalController.php
--- a/src/applications/diffusion/controller/DiffusionExternalController.php
+++ b/src/applications/diffusion/controller/DiffusionExternalController.php
@@ -131,7 +131,7 @@
$content = new PHUIObjectBoxView();
$content->setHeaderText(pht('Multiple Matching Commits'));
- $content->setErrorView($caption);
+ $content->setInfoView($caption);
$content->appendChild($table);
}
diff --git a/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php b/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php
--- a/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php
+++ b/src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php
@@ -301,7 +301,7 @@
'NOTE: You can only see your own signatures and signatures on '.
'documents you have permission to edit.'),
));
- $box->setErrorView($policy_notice);
+ $box->setInfoView($policy_notice);
}
return $box;
diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -270,7 +270,7 @@
$panel = new PHUIObjectBoxView();
$panel->setHeaderText($header);
if ($caption) {
- $panel->setErrorView($caption);
+ $panel->setInfoView($caption);
}
$panel->appendChild($table);
diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -351,7 +351,7 @@
->addPropertyList($properties);
if ($info_view) {
- $object_box->setErrorView($info_view);
+ $object_box->setInfoView($info_view);
}
if ($description) {
diff --git a/src/applications/people/controller/PhabricatorPeopleInviteSendController.php b/src/applications/people/controller/PhabricatorPeopleInviteSendController.php
--- a/src/applications/people/controller/PhabricatorPeopleInviteSendController.php
+++ b/src/applications/people/controller/PhabricatorPeopleInviteSendController.php
@@ -158,7 +158,7 @@
}
$confirm_box = id(new PHUIObjectBoxView())
- ->setErrorView(
+ ->setInfoView(
id(new PHUIInfoView())
->setErrors($confirm_errors)
->setSeverity($severity))
diff --git a/src/applications/phortune/controller/PhortuneCartViewController.php b/src/applications/phortune/controller/PhortuneCartViewController.php
--- a/src/applications/phortune/controller/PhortuneCartViewController.php
+++ b/src/applications/phortune/controller/PhortuneCartViewController.php
@@ -123,7 +123,7 @@
if ($errors) {
$cart_box->setFormErrors($errors);
} else if ($error_view) {
- $cart_box->setErrorView($error_view);
+ $cart_box->setInfoView($error_view);
}
$charges = id(new PhortuneChargeQuery())
diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
--- a/src/view/phui/PHUIObjectBoxView.php
+++ b/src/view/phui/PHUIObjectBoxView.php
@@ -6,7 +6,7 @@
private $headerColor;
private $formErrors = null;
private $formSaved = false;
- private $errorView;
+ private $infoView;
private $form;
private $validationException;
private $header;
@@ -113,8 +113,8 @@
return $this;
}
- public function setErrorView(PHUIInfoView $view) {
- $this->errorView = $view;
+ public function setInfoView(PHUIInfoView $view) {
+ $this->infoView = $view;
return $this;
}
@@ -269,7 +269,7 @@
->appendChild(
array(
$header,
- $this->errorView,
+ $this->infoView,
$this->formErrors,
$this->formSaved,
$exception_errors,
diff --git a/src/view/phui/calendar/PHUICalendarMonthView.php b/src/view/phui/calendar/PHUICalendarMonthView.php
--- a/src/view/phui/calendar/PHUICalendarMonthView.php
+++ b/src/view/phui/calendar/PHUICalendarMonthView.php
@@ -29,7 +29,7 @@
return $this;
}
- public function setErrorView(PHUIInfoView $error) {
+ public function setInfoView(PHUIInfoView $error) {
$this->error = $error;
return $this;
}
@@ -192,7 +192,7 @@
->setHeader($this->renderCalendarHeader($first))
->appendChild($table);
if ($this->error) {
- $box->setErrorView($this->error);
+ $box->setInfoView($this->error);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Oct 26, 5:22 AM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6741064
Default Alt Text
D12005.id28901.diff (10 KB)
Attached To
Mode
D12005: Change setErrorView to setInfoView in PHUIObjectBoxView
Attached
Detach File
Event Timeline
Log In to Comment