Page MenuHomePhabricator
Files F13999530

D9569.diff
No OneTemporary
Actions

D9569.diff
View Options

diff --git a/src/lint/linter/ArcanistBaseXHPASTLinter.php b/src/lint/linter/ArcanistBaseXHPASTLinter.php
--- a/src/lint/linter/ArcanistBaseXHPASTLinter.php
+++ b/src/lint/linter/ArcanistBaseXHPASTLinter.php
@@ -48,7 +48,7 @@
$replace);
}
- protected function buildFutures(array $paths) {
+ final protected function buildFutures(array $paths) {
return $this->getXHPASTLinter()->buildSharedFutures($paths);
}
@@ -69,7 +69,7 @@
* @return ArcanistBaseXHPASTLinter Responsible linter.
* @task sharing
*/
- protected function getXHPASTLinter() {
+ final protected function getXHPASTLinter() {
$resource_key = 'xhpast.linter';
// If we're the first linter to run, share ourselves. Otherwise, grab the
@@ -102,7 +102,7 @@
* @return list<ExecFuture> Futures.
* @task sharing
*/
- protected function buildSharedFutures(array $paths) {
+ final protected function buildSharedFutures(array $paths) {
foreach ($paths as $path) {
if (!isset($this->futures[$path])) {
$this->futures[$path] = xhpast_get_parser_future($this->getData($path));
@@ -119,7 +119,7 @@
* @return XHPASTTree|null Tree, or null if unparseable.
* @task sharing
*/
- protected function getXHPASTTreeForPath($path) {
+ final protected function getXHPASTTreeForPath($path) {
// If we aren't the linter responsible for actually building the parse
// trees, go get the tree from that linter.
@@ -152,7 +152,7 @@
* @return Exeption|null Parse exception, if available.
* @task sharing
*/
- protected function getXHPASTExceptionForPath($path) {
+ final protected function getXHPASTExceptionForPath($path) {
if ($this->getXHPASTLinter() !== $this) {
return $this->getXHPASTLinter()->getXHPASTExceptionForPath($path);
}
diff --git a/src/lint/linter/ArcanistLinter.php b/src/lint/linter/ArcanistLinter.php
--- a/src/lint/linter/ArcanistLinter.php
+++ b/src/lint/linter/ArcanistLinter.php
@@ -174,7 +174,7 @@
return $this->data[$path];
}
- public function setEngine(ArcanistLintEngine $engine) {
+ final public function setEngine(ArcanistLintEngine $engine) {
$this->engine = $engine;
return $this;
}
@@ -476,7 +476,7 @@
* @param wild Default value to return if key is not present in config.
* @return wild Configured value, or default if no configuration exists.
*/
- protected function getDeprecatedConfiguration($key, $default = null) {
+ final protected function getDeprecatedConfiguration($key, $default = null) {
// If we're being called in a context without an engine (probably from
// `arc linters`), just return the default value.

File Metadata

Mime Type
text/plain
Expires
Fri, Oct 25, 3:23 PM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6734960
Default Alt Text
D9569.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility