D16261.id39116.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D16261.id39116.diff
View Options

	diff --git a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
	--- a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
	+++ b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
	@@ -174,12 +174,13 @@
	continue;
	}

	- // In Git, it's possible to tag a tag. We just skip these, we'll discover
	- // them when we process the target tag. See T11180.
	+ // In Git, it's possible to tag anything. We just skip tags that don't
	+ // point to a commit. See T11301.
	$fields = $ref->getRawFields();
	+ $ref_type = idx($fields, 'objecttype');
	$tag_type = idx($fields, '*objecttype');
	- if ($tag_type == 'tag') {
	- $this->log(pht('Skipping, this is a tag of a tag.'));
	+ if ($ref_type != 'commit' && $tag_type != 'commit') {
	+ $this->log(pht('Skipping, this is not a commit.'));
	continue;
	}