Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13997838
D13341.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D13341.diff
View Options
diff --git a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
--- a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
@@ -77,20 +77,7 @@
$cmd = $lease->getInterface('command');
- if ($v_platform !== 'windows') {
- $cmd->execx('mkdir %s', $full_path);
- } else {
- // Windows is terrible. The mkdir command doesn't even support putting
- // the path in quotes. IN QUOTES. ARGUHRGHUGHHGG!! Do some terribly
- // inaccurate sanity checking since we can't safely escape the path.
- if (preg_match('/^[A-Z]\\:\\\\[a-zA-Z0-9\\\\\\ ]/', $full_path) === 0) {
- throw new Exception(
- pht(
- 'Unsafe path detected for Windows platform: "%s".',
- $full_path));
- }
- $cmd->execx('mkdir %C', $full_path);
- }
+ $cmd->execx('mkdir %s', $full_path);
$lease->setAttribute('path', $full_path);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Oct 25, 6:25 AM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6730511
Default Alt Text
D13341.diff (1 KB)
Attached To
Mode
D13341: Drop Windows-specific escaping in preallocated host
Attached
Detach File
Event Timeline
Log In to Comment