Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13996563
D9720.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D9720.diff
View Options
diff --git a/src/applications/project/controller/PhabricatorProjectMoveController.php b/src/applications/project/controller/PhabricatorProjectMoveController.php
--- a/src/applications/project/controller/PhabricatorProjectMoveController.php
+++ b/src/applications/project/controller/PhabricatorProjectMoveController.php
@@ -23,7 +23,6 @@
->requireCapabilities(
array(
PhabricatorPolicyCapability::CAN_VIEW,
- PhabricatorPolicyCapability::CAN_EDIT,
))
->withIDs(array($this->id))
->executeOne();
@@ -31,13 +30,14 @@
return new Aphront404Response();
}
- // NOTE: I'm not requiring EDIT on the object for now, since we require
- // EDIT on the project anyway and this relationship is more owned by the
- // project than the object. Maybe this is worth revisiting eventually.
-
$object = id(new PhabricatorObjectQuery())
->setViewer($viewer)
->withPHIDs(array($object_phid))
+ ->requireCapabilities(
+ array(
+ PhabricatorPolicyCapability::CAN_VIEW,
+ PhabricatorPolicyCapability::CAN_EDIT,
+ ))
->executeOne();
if (!$object) {
@@ -90,7 +90,11 @@
$tasks = id(new ManiphestTaskQuery())
->setViewer($viewer)
->withPHIDs($task_phids)
- ->requireCapabilities(array(PhabricatorPolicyCapability::CAN_EDIT))
+ ->requireCapabilities(
+ array(
+ PhabricatorPolicyCapability::CAN_VIEW,
+ PhabricatorPolicyCapability::CAN_EDIT,
+ ))
->execute();
if (count($tasks) != count($task_phids)) {
return new Aphront404Response();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Oct 24, 10:08 PM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6741735
Default Alt Text
D9720.diff (1 KB)
Attached To
Mode
D9720: When moving an object between workboard columns, require object edit permission
Attached
Detach File
Event Timeline
Log In to Comment