D9448.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D9448.diff
View Options

	diff --git a/src/lint/engine/ArcanistLintEngine.php b/src/lint/engine/ArcanistLintEngine.php
	--- a/src/lint/engine/ArcanistLintEngine.php
	+++ b/src/lint/engine/ArcanistLintEngine.php
	@@ -190,6 +190,10 @@
	return ArcanistDiffUtils::isHeuristicBinaryFile($data);
	}

	+ final public function isSymbolicLink($path) {
	+ return is_link($this->getFilePathOnDisk($path));
	+ }
	+
	final public function getFilePathOnDisk($path) {
	return Filesystem::resolvePath(
	$path,
	diff --git a/src/lint/linter/ArcanistFilenameLinter.php b/src/lint/linter/ArcanistFilenameLinter.php
	--- a/src/lint/linter/ArcanistFilenameLinter.php
	+++ b/src/lint/linter/ArcanistFilenameLinter.php
	@@ -49,4 +49,8 @@
	return true;
	}

	+ public function shouldLintSymbolicLinks() {
	+ return true;
	+ }
	+
	}
	diff --git a/src/lint/linter/ArcanistLinter.php b/src/lint/linter/ArcanistLinter.php
	--- a/src/lint/linter/ArcanistLinter.php
	+++ b/src/lint/linter/ArcanistLinter.php
	@@ -148,6 +148,10 @@
	continue;
	}

	+ if (!$this->shouldLintSymbolicLinks() && $engine->isSymbolicLink($path)) {
	+ continue;
	+ }
	+
	$keep[] = $path;
	}

	@@ -442,6 +446,10 @@
	return false;
	}

	+ protected function shouldLintSymbolicLinks() {
	+ return false;
	+ }
	+
	/**
	* Map a configuration lint code to an `arc` lint code. Primarily, this is
	* intended for validation, but can also be used to normalize case or