Page MenuHomePhabricator
Files F13989741

D14631.diff
No OneTemporary
Actions

D14631.diff
View Options

diff --git a/src/applications/calendar/util/CalendarTimeUtil.php b/src/applications/calendar/util/CalendarTimeUtil.php
--- a/src/applications/calendar/util/CalendarTimeUtil.php
+++ b/src/applications/calendar/util/CalendarTimeUtil.php
@@ -1,4 +1,5 @@
<?php
+
/**
* This class is useful for generating various time objects, relative to the
* user and their timezone.
diff --git a/src/applications/diviner/cache/DivinerAtomCache.php b/src/applications/diviner/cache/DivinerAtomCache.php
--- a/src/applications/diviner/cache/DivinerAtomCache.php
+++ b/src/applications/diviner/cache/DivinerAtomCache.php
@@ -13,7 +13,7 @@
private $writeAtoms = array();
public function __construct($cache_directory) {
- return parent::__construct($cache_directory, 'diviner-atom-cache');
+ parent::__construct($cache_directory, 'diviner-atom-cache');
}
public function delete() {
diff --git a/src/applications/diviner/cache/DivinerPublishCache.php b/src/applications/diviner/cache/DivinerPublishCache.php
--- a/src/applications/diviner/cache/DivinerPublishCache.php
+++ b/src/applications/diviner/cache/DivinerPublishCache.php
@@ -6,7 +6,7 @@
private $index;
public function __construct($cache_directory) {
- return parent::__construct($cache_directory, 'diviner-publish-cache');
+ parent::__construct($cache_directory, 'diviner-publish-cache');
}
diff --git a/src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php b/src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php
--- a/src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php
@@ -143,7 +143,7 @@
*/
private function getWritableEngine() {
// NOTE: We can't just load writable engines or we'll loop forever.
- $engines = PhabricatorFileStorageEngine::loadAllEngines();
+ $engines = parent::loadAllEngines();
foreach ($engines as $engine) {
if ($engine->isChunkEngine()) {
diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php
--- a/src/applications/home/controller/PhabricatorHomeMainController.php
+++ b/src/applications/home/controller/PhabricatorHomeMainController.php
@@ -219,7 +219,7 @@
$revisions = $revision_query->execute();
- list($blocking, $active,) = DifferentialRevisionQuery::splitResponsible(
+ list($blocking, $active) = DifferentialRevisionQuery::splitResponsible(
$revisions,
array($user_phid));
diff --git a/src/applications/oauthserver/PhabricatorOAuthResponse.php b/src/applications/oauthserver/PhabricatorOAuthResponse.php
--- a/src/applications/oauthserver/PhabricatorOAuthResponse.php
+++ b/src/applications/oauthserver/PhabricatorOAuthResponse.php
@@ -65,8 +65,7 @@
}
public function __construct() {
- $this->setHTTPResponseCode(200); // assume the best
- return $this;
+ $this->setHTTPResponseCode(200); // assume the best
}
public function getHeaders() {
diff --git a/src/applications/oauthserver/PhabricatorOAuthServer.php b/src/applications/oauthserver/PhabricatorOAuthServer.php
--- a/src/applications/oauthserver/PhabricatorOAuthServer.php
+++ b/src/applications/oauthserver/PhabricatorOAuthServer.php
@@ -64,8 +64,8 @@
*/
public function userHasAuthorizedClient(array $scope) {
- $authorization = id(new PhabricatorOAuthClientAuthorization())->
- loadOneWhere(
+ $authorization = id(new PhabricatorOAuthClientAuthorization())
+ ->loadOneWhere(
'userPHID = %s AND clientPHID = %s',
$this->getUser()->getPHID(),
$this->getClient()->getPHID());
diff --git a/src/applications/phame/controller/PhameController.php b/src/applications/phame/controller/PhameController.php
--- a/src/applications/phame/controller/PhameController.php
+++ b/src/applications/phame/controller/PhameController.php
@@ -1,5 +1,3 @@
<?php
-abstract class PhameController extends PhabricatorController {
-
-}
+abstract class PhameController extends PhabricatorController {}
diff --git a/src/applications/releeph/storage/ReleephRequestTransaction.php b/src/applications/releeph/storage/ReleephRequestTransaction.php
--- a/src/applications/releeph/storage/ReleephRequestTransaction.php
+++ b/src/applications/releeph/storage/ReleephRequestTransaction.php
@@ -77,7 +77,7 @@
$markup = $name;
if ($this->getRenderingTarget() ===
- PhabricatorApplicationTransaction::TARGET_HTML) {
+ parent::TARGET_HTML) {
$markup = hsprintf('<em>%s</em>', $name);
}
diff --git a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
--- a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
+++ b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
@@ -85,7 +85,7 @@
}
public function getCacheGranularity() {
- return ArcanistLinter::GRANULARITY_REPOSITORY;
+ return parent::GRANULARITY_REPOSITORY;
}
public function getCacheVersion() {
diff --git a/src/view/widget/bars/AphrontGlyphBarView.php b/src/view/widget/bars/AphrontGlyphBarView.php
--- a/src/view/widget/bars/AphrontGlyphBarView.php
+++ b/src/view/widget/bars/AphrontGlyphBarView.php
@@ -12,7 +12,7 @@
private $bgGlyph;
protected function getDefaultColor() {
- return AphrontBarView::COLOR_AUTO_GOODNESS;
+ return parent::COLOR_AUTO_GOODNESS;
}
public function setValue($value) {
diff --git a/src/view/widget/bars/AphrontProgressBarView.php b/src/view/widget/bars/AphrontProgressBarView.php
--- a/src/view/widget/bars/AphrontProgressBarView.php
+++ b/src/view/widget/bars/AphrontProgressBarView.php
@@ -9,7 +9,7 @@
private $alt = '';
protected function getDefaultColor() {
- return AphrontBarView::COLOR_AUTO_BADNESS;
+ return parent::COLOR_AUTO_BADNESS;
}
public function setValue($value) {

File Metadata

Mime Type
text/plain
Expires
Tue, Oct 22, 10:45 PM (3 w, 4 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6731456
Default Alt Text
D14631.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility