Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13986070
D17909.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D17909.id.diff
View Options
diff --git a/src/applications/project/controller/PhabricatorProjectBoardManageController.php b/src/applications/project/controller/PhabricatorProjectBoardManageController.php
--- a/src/applications/project/controller/PhabricatorProjectBoardManageController.php
+++ b/src/applications/project/controller/PhabricatorProjectBoardManageController.php
@@ -31,6 +31,7 @@
$board_id = $board->getID();
$header = $this->buildHeaderView($board);
+ $curtain = $this->buildCurtainView($board);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Workboard'), "/project/board/{$board_id}/");
@@ -46,7 +47,8 @@
->setHeader($header)
->addClass('project-view-home')
->addClass('project-view-people-home')
- ->setFooter($columns_list);
+ ->setCurtain($curtain)
+ ->setMainColumn($columns_list);
$title = array(
pht('Manage Workboard'),
@@ -63,29 +65,35 @@
private function buildHeaderView(PhabricatorProject $board) {
$viewer = $this->getViewer();
+ $header = id(new PHUIHeaderView())
+ ->setHeader(pht('Workboard: %s', $board->getDisplayName()))
+ ->setUser($viewer);
+
+ return $header;
+ }
+
+ private function buildCurtainView(PhabricatorProject $board) {
+ $viewer = $this->getViewer();
+ $id = $board->getID();
+
+ $curtain = $this->newCurtainView();
+
$can_edit = PhabricatorPolicyFilter::hasCapability(
$viewer,
$board,
PhabricatorPolicyCapability::CAN_EDIT);
- $id = $board->getID();
$disable_uri = $this->getApplicationURI("board/{$id}/disable/");
- $button = id(new PHUIButtonView())
- ->setTag('a')
- ->setIcon('fa-ban')
- ->setText(pht('Disable Board'))
- ->setHref($disable_uri)
- ->setDisabled(!$can_edit)
- ->setWorkflow(true);
+ $curtain->addAction(
+ id(new PhabricatorActionView())
+ ->setIcon('fa-ban')
+ ->setName(pht('Disable Workboard'))
+ ->setHref($disable_uri)
+ ->setDisabled(!$can_edit)
+ ->setWorkflow(true));
- $header = id(new PHUIHeaderView())
- ->setHeader(pht('Workboard: %s', $board->getDisplayName()))
- ->setUser($viewer)
- ->setProfileHeader(true)
- ->addActionLink($button);
-
- return $header;
+ return $curtain;
}
private function buildColumnsList(
@@ -126,6 +134,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('Columns'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($view);
}
diff --git a/src/applications/project/controller/PhabricatorProjectColumnDetailController.php b/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
@@ -75,8 +75,7 @@
$header = id(new PHUIHeaderView())
->setHeader(pht('Column: %s', $column->getDisplayName()))
- ->setUser($viewer)
- ->setProfileHeader(true);
+ ->setUser($viewer);
if ($column->isHidden()) {
$header->setStatus('fa-ban', 'dark', pht('Hidden'));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Oct 22, 12:25 AM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6730380
Default Alt Text
D17909.id.diff (3 KB)
Attached To
Mode
D17909: Normalize headers and actions in Project sub pages
Attached
Detach File
Event Timeline
Log In to Comment