Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13981444
D10536.id25347.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D10536.id25347.diff
View Options
diff --git a/src/lint/linter/ArcanistTextLinter.php b/src/lint/linter/ArcanistTextLinter.php
--- a/src/lint/linter/ArcanistTextLinter.php
+++ b/src/lint/linter/ArcanistTextLinter.php
@@ -128,7 +128,7 @@
$this->raiseLintAtOffset(
$pos,
self::LINT_DOS_NEWLINE,
- 'You must use ONLY Unix linebreaks ("\n") in source code.',
+ pht('You must use ONLY Unix linebreaks ("%s") in source code.', '\n'),
"\r");
if ($this->isMessageEnabled(self::LINT_DOS_NEWLINE)) {
$this->stopAllLinters();
@@ -142,7 +142,7 @@
$this->raiseLintAtOffset(
$pos,
self::LINT_TAB_LITERAL,
- 'Configure your editor to use spaces for indentation.',
+ pht('Configure your editor to use spaces for indentation.'),
"\t");
}
}
@@ -157,8 +157,11 @@
$line_idx + 1,
1,
self::LINT_LINE_WRAP,
- 'This line is '.number_format(strlen($line)).' characters long, '.
- 'but the convention is '.$width.' characters.',
+ pht(
+ 'This line is %s characters long, but the '.
+ 'convention is %s characters.',
+ new PhutilNumber(strlen($line)),
+ $width),
$line);
}
}
@@ -170,7 +173,7 @@
$this->raiseLintAtOffset(
strlen($data),
self::LINT_EOF_NEWLINE,
- 'Files must end in a newline.',
+ pht('Files must end in a newline.'),
'',
"\n");
}
@@ -196,9 +199,10 @@
$this->raiseLintAtOffset(
$offset,
self::LINT_BAD_CHARSET,
- 'Source code should contain only ASCII bytes with ordinal decimal '.
- 'values between 32 and 126 inclusive, plus linefeed. Do not use UTF-8 '.
- 'or other multibyte charsets.',
+ pht(
+ 'Source code should contain only ASCII bytes with ordinal '.
+ 'decimal values between 32 and 126 inclusive, plus linefeed. '.
+ 'Do not use UTF-8 or other multibyte charsets.'),
$string);
}
@@ -226,9 +230,10 @@
$this->raiseLintAtOffset(
$offset,
self::LINT_TRAILING_WHITESPACE,
- 'This line contains trailing whitespace. Consider setting up your '.
- 'editor to automatically remove trailing whitespace, you will save '.
- 'time.',
+ pht(
+ 'This line contains trailing whitespace. Consider setting '.
+ 'up your editor to automatically remove trailing whitespace, '.
+ 'you will save time.'),
$string,
'');
}
@@ -252,8 +257,9 @@
$this->raiseLintAtOffset(
$offset,
self::LINT_BOF_WHITESPACE,
- 'This file contains leading whitespace at the beginning of the file. '.
- 'This is unnecessary and should be avoided when possible.',
+ pht(
+ 'This file contains leading whitespace at the beginning of the file. '.
+ 'This is unnecessary and should be avoided when possible.'),
$string,
'');
}
@@ -276,8 +282,9 @@
$this->raiseLintAtOffset(
$offset,
self::LINT_EOF_WHITESPACE,
- 'This file contains trailing whitespace at the end of the file. This '.
- 'is unnecessary and should be avoided when possible.',
+ pht(
+ 'This file contains trailing whitespace at the end of the file. '.
+ 'This is unnecessary and should be avoided when possible.'),
$string,
'');
}
@@ -292,8 +299,9 @@
$this->raiseLintAtOffset(
$offset,
self::LINT_NO_COMMIT,
- 'This file is explicitly marked as "'.$deadly.'", which blocks '.
- 'commits.',
+ pht(
+ 'This file is explicitly marked as "%s", which blocks commits.',
+ $deadly),
$deadly);
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Oct 20, 4:35 PM (3 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6733582
Default Alt Text
D10536.id25347.diff (3 KB)
Attached To
Mode
D10536: `pht`ize some strings
Attached
Detach File
Event Timeline
Log In to Comment