Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13979005
D8056.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D8056.diff
View Options
Index: src/__phutil_library_map__.php
===================================================================
--- src/__phutil_library_map__.php
+++ src/__phutil_library_map__.php
@@ -170,6 +170,7 @@
'PhutilGitURITestCase' => 'parser/__tests__/PhutilGitURITestCase.php',
'PhutilHangForeverDaemon' => 'daemon/torture/PhutilHangForeverDaemon.php',
'PhutilHelpArgumentWorkflow' => 'parser/argument/workflow/PhutilHelpArgumentWorkflow.php',
+ 'PhutilInfrastructureTestCase' => 'infrastructure/__tests__/PhutilInfrastructureTestCase.php',
'PhutilInteractiveEditor' => 'console/PhutilInteractiveEditor.php',
'PhutilInvisibleSyntaxHighlighter' => 'markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php',
'PhutilJSON' => 'parser/PhutilJSON.php',
@@ -242,7 +243,6 @@
'PhutilRemarkupBlockStorage' => 'markup/engine/remarkup/PhutilRemarkupBlockStorage.php',
'PhutilRemarkupEngine' => 'markup/engine/PhutilRemarkupEngine.php',
'PhutilRemarkupEngineBlockRule' => 'markup/engine/remarkup/blockrule/PhutilRemarkupEngineBlockRule.php',
- 'PhutilRemarkupEngineRemarkupBubbleBlockRule' => 'markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupBubbleBlockRule.php',
'PhutilRemarkupEngineRemarkupCodeBlockRule' => 'markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupCodeBlockRule.php',
'PhutilRemarkupEngineRemarkupDefaultBlockRule' => 'markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupDefaultBlockRule.php',
'PhutilRemarkupEngineRemarkupHeaderBlockRule' => 'markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHeaderBlockRule.php',
@@ -553,6 +553,7 @@
'PhutilGitURITestCase' => 'PhutilTestCase',
'PhutilHangForeverDaemon' => 'PhutilTortureTestDaemon',
'PhutilHelpArgumentWorkflow' => 'PhutilArgumentWorkflow',
+ 'PhutilInfrastructureTestCase' => 'PhutilTestCase',
'PhutilJSONProtocolChannel' => 'PhutilProtocolChannel',
'PhutilJSONProtocolChannelTestCase' => 'PhutilTestCase',
'PhutilJSONTestCase' => 'PhutilTestCase',
@@ -603,7 +604,6 @@
'PhutilReadableSerializerTestCase' => 'PhutilTestCase',
'PhutilRealnameContextFreeGrammar' => 'PhutilContextFreeGrammar',
'PhutilRemarkupEngine' => 'PhutilMarkupEngine',
- 'PhutilRemarkupEngineRemarkupBubbleBlockRule' => 'PhutilRemarkupEngineBlockRule',
'PhutilRemarkupEngineRemarkupCodeBlockRule' => 'PhutilRemarkupEngineBlockRule',
'PhutilRemarkupEngineRemarkupDefaultBlockRule' => 'PhutilRemarkupEngineBlockRule',
'PhutilRemarkupEngineRemarkupHeaderBlockRule' => 'PhutilRemarkupEngineBlockRule',
Index: src/infrastructure/__tests__/PhutilInfrastructureTestCase.php
===================================================================
--- /dev/null
+++ src/infrastructure/__tests__/PhutilInfrastructureTestCase.php
@@ -0,0 +1,12 @@
+<?php
+
+final class PhutilInfrastructureTestCase extends PhutilTestCase {
+ /**
+ * This is more of an acceptance test case instead of a unit test. It verifies
+ * that all symbols can be loaded correctly. It can catch problems like
+ * missing methods in descendants of abstract base classes.
+ */
+ public function testEverythingImplemented() {
+ id(new PhutilSymbolLoader())->selectAndLoadSymbols();
+ }
+}
Index: src/phage/bootloader/PhagePHPAgentBootloader.php
===================================================================
--- src/phage/bootloader/PhagePHPAgentBootloader.php
+++ src/phage/bootloader/PhagePHPAgentBootloader.php
@@ -41,6 +41,7 @@
$files = array(
'utils/utils.php',
'object/Phobject.php',
+ 'utils/PhutilRope.php',
'xsprintf/xsprintf.php',
'xsprintf/csprintf.php',
'xsprintf/PhutilCommandString.php',
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Oct 20, 2:01 AM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6710829
Default Alt Text
D8056.diff (3 KB)
Attached To
Mode
D8056: Fixed missing symbols
Attached
Detach File
Event Timeline
Log In to Comment