Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13975516
D10549.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D10549.id.diff
View Options
diff --git a/src/applications/differential/customfield/DifferentialRepositoryField.php b/src/applications/differential/customfield/DifferentialRepositoryField.php
--- a/src/applications/differential/customfield/DifferentialRepositoryField.php
+++ b/src/applications/differential/customfield/DifferentialRepositoryField.php
@@ -107,19 +107,25 @@
$old = $xaction->getOldValue();
$new = $xaction->getNewValue();
- if ($old) {
+ if ($old && $new) {
return pht(
'%s updated the repository for %s from %s to %s.',
$xaction->renderHandleLink($author_phid),
$xaction->renderHandleLink($object_phid),
$xaction->renderHandleLink($old),
$xaction->renderHandleLink($new));
- } else {
+ } else if ($new) {
return pht(
'%s set the repository for %s to %s.',
$xaction->renderHandleLink($author_phid),
$xaction->renderHandleLink($object_phid),
$xaction->renderHandleLink($new));
+ } else {
+ return pht(
+ '%s removed the repository for %s. (Repository was %s.)',
+ $xaction->renderHandleLink($author_phid),
+ $xaction->renderHandleLink($object_phid),
+ $xaction->renderHandleLink($old));
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Oct 19 2024, 10:28 AM (4 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6731673
Default Alt Text
D10549.id.diff (1 KB)
Attached To
Mode
D10549: Support - Differential - fix rendering feed story where you removed a repository
Attached
Detach File
Event Timeline
Log In to Comment