Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13975040
D11688.id28198.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
967 B
Referenced Files
None
Subscribers
None
D11688.id28198.diff
View Options
diff --git a/src/future/exec/ExecFuture.php b/src/future/exec/ExecFuture.php
--- a/src/future/exec/ExecFuture.php
+++ b/src/future/exec/ExecFuture.php
@@ -599,24 +599,7 @@
}
do {
- $real_length = $length;
-
- // On Windows, we must check to see if we can read without blocking
- // from the stream, and even then we must read only 1 byte at a time.
- if ($this->useWindowsFileStreams) {
- $r = array($stream);
- $w = array();
- $e = array();
- if (false === stream_select($r, $w, $e, 0)) {
- throw new Exception('stream_select() failed');
- }
- $real_length = 0;
- if (in_array($stream, $r)) {
- $real_length = 1;
- }
- }
-
- $data = fread($stream, min($real_length, 64 * 1024));
+ $data = fread($stream, min($length, 64 * 1024));
if (false === $data) {
throw new Exception('Failed to read from '.$description);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Oct 19, 8:26 AM (4 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6731212
Default Alt Text
D11688.id28198.diff (967 B)
Attached To
Mode
D11688: Support non-blocking reads for ExecFuture on Windows
Attached
Detach File
Event Timeline
Log In to Comment