Page MenuHomePhabricator
Files F13973595

D15404.diff
No OneTemporary
Actions

D15404.diff
View Options

diff --git a/src/applications/almanac/controller/AlmanacBindingViewController.php b/src/applications/almanac/controller/AlmanacBindingViewController.php
--- a/src/applications/almanac/controller/AlmanacBindingViewController.php
+++ b/src/applications/almanac/controller/AlmanacBindingViewController.php
@@ -26,26 +26,23 @@
$title = pht('Binding %s', $binding->getID());
- $property_list = $this->buildPropertyList($binding);
- $action_list = $this->buildActionList($binding);
- $property_list->setActionList($action_list);
+ $properties = $this->buildPropertyList($binding);
+ $details = $this->buildPropertySection($binding);
+ $actions = $this->buildActionList($binding);
$header = id(new PHUIHeaderView())
->setUser($viewer)
->setHeader($title)
- ->setPolicyObject($binding);
+ ->setPolicyObject($binding)
+ ->setHeaderIcon('fa-object-group');
if ($binding->getIsDisabled()) {
$header->setStatus('fa-ban', 'red', pht('Disabled'));
}
- $box = id(new PHUIObjectBoxView())
- ->setHeader($header)
- ->addPropertyList($property_list);
-
+ $issue = null;
if ($binding->getService()->isClusterService()) {
- $this->addClusterMessage(
- $box,
+ $issue = $this->addClusterMessage(
pht('The service for this binding is a cluster service.'),
pht(
'The service for this binding is a cluster service. You do not '.
@@ -56,24 +53,34 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($service->getName(), $service_uri);
$crumbs->addTextCrumb($title);
+ $crumbs->setBorder(true);
$timeline = $this->buildTransactionTimeline(
$binding,
new AlmanacBindingTransactionQuery());
$timeline->setShouldTerminate(true);
+ $view = id(new PHUITwoColumnView())
+ ->setHeader($header)
+ ->setMainColumn(array(
+ $issue,
+ $this->buildAlmanacPropertiesTable($binding),
+ $timeline,
+ ))
+ ->setPropertyList($properties)
+ ->addPropertySection(pht('DETAILS'), $details)
+ ->setActionList($actions);
+
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->appendChild(
array(
- $box,
- $this->buildAlmanacPropertiesTable($binding),
- $timeline,
+ $view,
));
}
- private function buildPropertyList(AlmanacBinding $binding) {
+ private function buildPropertySection(AlmanacBinding $binding) {
$viewer = $this->getViewer();
$properties = id(new PHUIPropertyListView())
@@ -98,6 +105,17 @@
return $properties;
}
+ private function buildPropertyList(AlmanacBinding $binding) {
+ $viewer = $this->getViewer();
+
+ $properties = id(new PHUIPropertyListView())
+ ->setUser($viewer)
+ ->setObject($binding);
+ $properties->invokeWillRenderEvent();
+
+ return $properties;
+ }
+
private function buildActionList(AlmanacBinding $binding) {
$viewer = $this->getViewer();
$id = $binding->getID();

File Metadata

Mime Type
text/plain
Expires
Oct 19 2024, 1:36 AM (4 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6712479
Default Alt Text
D15404.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility