Page MenuHomePhabricator
Files F13973172

D17076.diff
No OneTemporary
Actions

D17076.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -473,7 +473,6 @@
'DifferentialMailView' => 'applications/differential/mail/DifferentialMailView.php',
'DifferentialManiphestTasksField' => 'applications/differential/customfield/DifferentialManiphestTasksField.php',
'DifferentialModernHunk' => 'applications/differential/storage/DifferentialModernHunk.php',
- 'DifferentialNextStepField' => 'applications/differential/customfield/DifferentialNextStepField.php',
'DifferentialParentRevisionsField' => 'applications/differential/customfield/DifferentialParentRevisionsField.php',
'DifferentialParseCacheGarbageCollector' => 'applications/differential/garbagecollector/DifferentialParseCacheGarbageCollector.php',
'DifferentialParseCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php',
@@ -5128,7 +5127,6 @@
'DifferentialMailView' => 'Phobject',
'DifferentialManiphestTasksField' => 'DifferentialCoreCustomField',
'DifferentialModernHunk' => 'DifferentialHunk',
- 'DifferentialNextStepField' => 'DifferentialCustomField',
'DifferentialParentRevisionsField' => 'DifferentialCustomField',
'DifferentialParseCacheGarbageCollector' => 'PhabricatorGarbageCollector',
'DifferentialParseCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -25,8 +25,6 @@
$custom_field_type = 'custom:PhabricatorCustomFieldConfigOptionType';
$fields = array(
- new DifferentialNextStepField(),
-
new DifferentialTitleField(),
new DifferentialSummaryField(),
new DifferentialTestPlanField(),
diff --git a/src/applications/differential/customfield/DifferentialNextStepField.php b/src/applications/differential/customfield/DifferentialNextStepField.php
deleted file mode 100644
--- a/src/applications/differential/customfield/DifferentialNextStepField.php
+++ /dev/null
@@ -1,65 +0,0 @@
-<?php
-
-final class DifferentialNextStepField
- extends DifferentialCustomField {
-
- public function getFieldKey() {
- return 'differential:next-step';
- }
-
- public function getFieldName() {
- return pht('Next Step');
- }
-
- public function getFieldDescription() {
- return pht('Provides a hint for the next step to take.');
- }
-
- public function shouldAppearInPropertyView() {
- return true;
- }
-
- public function renderPropertyViewLabel() {
- return $this->getFieldName();
- }
-
- public function renderPropertyViewValue(array $handles) {
- $revision = $this->getObject();
- $diff = $revision->getActiveDiff();
-
- $status = $revision->getStatus();
- if ($status != ArcanistDifferentialRevisionStatus::ACCEPTED) {
- return null;
- }
-
- $local_vcs = $diff->getSourceControlSystem();
- switch ($local_vcs) {
- case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
- $bookmark = $diff->getBookmark();
- if (strlen($bookmark)) {
- $next_step = csprintf('arc land %R', $bookmark);
- } else {
- $next_step = csprintf('arc land');
- }
- break;
- case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
- $branch = $diff->getBranch();
- if (strlen($branch)) {
- $next_step = csprintf('arc land %R', $branch);
- } else {
- $next_step = csprintf('arc land');
- }
- break;
- case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
- $next_step = csprintf('arc commit');
- break;
- default:
- return null;
- }
-
- $next_step = phutil_tag('tt', array(), (string)$next_step);
-
- return $next_step;
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Oct 18 2024, 11:30 PM (4 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6727857
Default Alt Text
D17076.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility