D17851.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D17851.diff
View Options

	diff --git a/src/applications/passphrase/controller/PassphraseCredentialEditController.php b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
	--- a/src/applications/passphrase/controller/PassphraseCredentialEditController.php
	+++ b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
	@@ -244,8 +244,8 @@
	->setValue($v_name)
	->setError($e_name))
	->appendChild(
	- id(new AphrontFormTextAreaControl())
	- ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)
	+ id(new PhabricatorRemarkupControl())
	+ ->setUser($viewer)
	->setName('description')
	->setLabel(pht('Description'))
	->setValue($v_desc))
	diff --git a/src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php b/src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php
	--- a/src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php
	+++ b/src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php
	@@ -17,17 +17,9 @@
	$object->setSecretID($value);
	}

	- public function shouldHide() {
	- if (!$this->getOldValue()) {
	- return true;
	- }
	-
	- return false;
	- }
	-
	public function getTitle() {
	$old = $this->getOldValue();
	- if ($old === null) {
	+ if (!$old) {
	return pht(
	'%s attached a new secret to this credential.',
	$this->renderAuthor());
	@@ -53,4 +45,8 @@
	}
	}

	+ public function getIcon() {
	+ return 'fa-key';
	+ }
	+
	}