Page MenuHomePhabricator

D8934.id21198.diff
No OneTemporary

D8934.id21198.diff

diff --git a/src/applications/harbormaster/controller/HarbormasterBuildableListController.php b/src/applications/harbormaster/controller/HarbormasterBuildableListController.php
--- a/src/applications/harbormaster/controller/HarbormasterBuildableListController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildableListController.php
@@ -32,7 +32,7 @@
$viewer = $this->getRequest()->getUser();
$list = new PHUIObjectItemListView();
- $list->setStates(true);
+ $list->setCards(true);
foreach ($buildables as $buildable) {
$id = $buildable->getID();
@@ -55,28 +55,25 @@
switch ($buildable->getBuildableStatus()) {
case HarbormasterBuildable::STATUS_PASSED:
- $item->setState(PHUIObjectItemView::STATE_SUCCESS);
+ $item->setBarColor('green');
+ $item->addByline(pht('Build Passed'));
break;
case HarbormasterBuildable::STATUS_FAILED:
- $item->setState(PHUIObjectItemView::STATE_FAIL);
+ $item->setBarColor('red');
+ $item->addByline(pht('Build Failed'));
break;
case HarbormasterBuildable::STATUS_BUILDING:
- $item->setState(PHUIObjectItemView::STATE_BUILD);
- break;
- default:
- $item->setState(PHUIObjectItemView::STATE_WARN);
+ $item->setBarColor('red');
+ $item->addByline(pht('Building'));
break;
+
}
$list->addItem($item);
}
- $box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Buildables'))
- ->appendChild($list);
-
- return $box;
+ return $list;
}
public function buildSideNavView($for_app = false) {

File Metadata

Mime Type
text/plain
Expires
Fri, Oct 18, 11:15 AM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6726586
Default Alt Text
D8934.id21198.diff (1 KB)

Event Timeline