Page MenuHomePhabricator

D9688.diff
No OneTemporary

D9688.diff

diff --git a/src/applications/diffusion/view/DiffusionHistoryTableView.php b/src/applications/diffusion/view/DiffusionHistoryTableView.php
--- a/src/applications/diffusion/view/DiffusionHistoryTableView.php
+++ b/src/applications/diffusion/view/DiffusionHistoryTableView.php
@@ -66,24 +66,24 @@
if ($this->buildCache !== null) {
return $this->buildCache;
}
-
+
$commits_to_builds = array();
-
+
$commits = mpull($this->history, 'getCommit');
-
+
$commit_phids = mpull($commits, 'getPHID');
-
+
$buildables = id(new HarbormasterBuildableQuery())
->setViewer($this->getUser())
->withBuildablePHIDs($commit_phids)
->withManualBuildables(false)
->execute();
-
+
$this->buildCache = mpull($buildables, null, 'getBuildablePHID');
-
+
return $this->buildCache;
}
-
+
public function render() {
$drequest = $this->getDiffusionRequest();
@@ -97,7 +97,7 @@
$show_builds = PhabricatorApplication::isClassInstalledForViewer(
'PhabricatorApplicationHarbormaster',
$this->getUser());
-
+
$rows = array();
$ii = 0;
foreach ($this->history as $history) {
@@ -163,30 +163,30 @@
$buildable->getBuildableStatus());
$name = HarbormasterBuildable::getBuildableStatusName(
$buildable->getBuildableStatus());
-
+
$icon_view = id(new PHUIIconView())
->setIconFont($icon.' '.$color);
-
+
$tooltip_view = javelin_tag(
'span',
array(
'sigil' => 'has-tooltip',
'meta' => array('tip' => $name)),
$icon_view);
-
+
Javelin::initBehavior('phabricator-tooltips');
-
+
$href_view = phutil_tag(
'a',
array('href' => '/'.$buildable->getMonogram()),
$tooltip_view);
-
+
$build = $href_view;
-
+
$has_any_build = true;
}
}
-
+
$rows[] = array(
$graph ? $graph[$ii++] : null,
self::linkCommit(
@@ -202,7 +202,7 @@
$time,
);
}
-
+
$view = new AphrontTableView($rows);
$view->setHeaders(
array(
diff --git a/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php b/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php
--- a/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php
+++ b/src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php
@@ -208,7 +208,7 @@
if ($buildable->getIsManualBuildable()) {
$item->addIcon('fa-wrench grey', pht('Manual'));
}
-
+
$item->setBarColor(HarbormasterBuildable::getBuildableStatusColor(
$buildable->getBuildableStatus()));
$item->addByline(HarbormasterBuildable::getBuildableStatusName(

File Metadata

Mime Type
text/plain
Expires
Oct 17 2024, 7:01 PM (4 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6723081
Default Alt Text
D9688.diff (2 KB)

Event Timeline