Page MenuHomePhabricator
Files F13967548

D12782.id30801.diff
No OneTemporary
Actions

D12782.id30801.diff
View Options

diff --git a/src/applications/celerity/CelerityStaticResourceResponse.php b/src/applications/celerity/CelerityStaticResourceResponse.php
--- a/src/applications/celerity/CelerityStaticResourceResponse.php
+++ b/src/applications/celerity/CelerityStaticResourceResponse.php
@@ -33,14 +33,16 @@
}
/**
- * Register a behavior for initialization. NOTE: if $config is empty,
- * a behavior will execute only once even if it is initialized multiple times.
- * If $config is nonempty, the behavior will be invoked once for each config.
+ * Register a behavior for initialization.
+ *
+ * NOTE: If `$config` is empty, a behavior will execute only once even if it
+ * is initialized multiple times. If `$config` is nonempty, the behavior will
+ * be invoked once for each configuration.
*/
public function initBehavior(
$behavior,
array $config = array(),
- $source_name) {
+ $source_name = null) {
$this->requireResource('javelin-behavior-'.$behavior, $source_name);
diff --git a/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
--- a/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
@@ -353,7 +353,7 @@
public static function writeLog(
DrydockResource $resource = null,
DrydockLease $lease = null,
- $message) {
+ $message = null) {
$log = id(new DrydockLog())
->setEpoch(time())
diff --git a/src/applications/people/storage/PhabricatorUserLog.php b/src/applications/people/storage/PhabricatorUserLog.php
--- a/src/applications/people/storage/PhabricatorUserLog.php
+++ b/src/applications/people/storage/PhabricatorUserLog.php
@@ -86,7 +86,7 @@
public static function initializeNewLog(
- PhabricatorUser $actor = null,
+ PhabricatorUser $actor,
$object_phid,
$action) {
diff --git a/src/applications/phragment/storage/PhragmentFragment.php b/src/applications/phragment/storage/PhragmentFragment.php
--- a/src/applications/phragment/storage/PhragmentFragment.php
+++ b/src/applications/phragment/storage/PhragmentFragment.php
@@ -77,7 +77,7 @@
*/
public static function createFromFile(
PhabricatorUser $viewer,
- PhabricatorFile $file = null,
+ PhabricatorFile $file,
$path,
$view_policy,
$edit_policy) {
diff --git a/src/view/layout/AphrontSideNavFilterView.php b/src/view/layout/AphrontSideNavFilterView.php
--- a/src/view/layout/AphrontSideNavFilterView.php
+++ b/src/view/layout/AphrontSideNavFilterView.php
@@ -125,12 +125,7 @@
$key, $name, $uri, PHUIListItemView::TYPE_BUTTON);
}
- private function addThing(
- $key,
- $name,
- $uri = null,
- $type) {
-
+ private function addThing($key, $name, $uri, $type) {
$item = id(new PHUIListItemView())
->setName($name)
->setType($type);

File Metadata

Mime Type
text/plain
Expires
Oct 17 2024, 2:25 PM (4 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6722384
Default Alt Text
D12782.id30801.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility