Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13966310
D18654.id44789.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D18654.id44789.diff
View Options
diff --git a/src/repository/api/ArcanistGitAPI.php b/src/repository/api/ArcanistGitAPI.php
--- a/src/repository/api/ArcanistGitAPI.php
+++ b/src/repository/api/ArcanistGitAPI.php
@@ -1054,7 +1054,12 @@
}
public function getBaseCommitRef() {
- $base_commit = $this->getSourceControlBaseRevision();
+ $base_commit = $this->getBaseCommit();
+
+ if ($base_commit === self::GIT_MAGIC_ROOT_COMMIT) {
+ return null;
+ }
+
$base_message = $this->getCommitMessage($base_commit);
// TODO: We should also pull the tree hash.
diff --git a/src/repository/api/ArcanistMercurialAPI.php b/src/repository/api/ArcanistMercurialAPI.php
--- a/src/repository/api/ArcanistMercurialAPI.php
+++ b/src/repository/api/ArcanistMercurialAPI.php
@@ -596,6 +596,20 @@
return $refs;
}
+ public function getBaseCommitRef() {
+ $base_commit = $this->getBaseCommit();
+
+ if ($base_commit === 'null') {
+ return null;
+ }
+
+ $base_message = $this->getCommitMessage($base_commit);
+
+ return $this->newCommitRef()
+ ->setCommitHash($base_commit)
+ ->attachMessage($base_message);
+ }
+
public function hasLocalCommit($commit) {
try {
$this->getCanonicalRevisionName($commit);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Oct 17, 7:29 AM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6721150
Default Alt Text
D18654.id44789.diff (1 KB)
Attached To
Mode
D18654: Support automatic "Depends On" detection in Mercurial
Attached
Detach File
Event Timeline
Log In to Comment