D15675.id37768.diff
No OneTemporary
Actions

Size

918 B

Referenced Files

None

Subscribers

None

D15675.id37768.diff
View Options

	diff --git a/src/xsprintf/PhutilCommandString.php b/src/xsprintf/PhutilCommandString.php
	--- a/src/xsprintf/PhutilCommandString.php
	+++ b/src/xsprintf/PhutilCommandString.php
	@@ -11,7 +11,7 @@
	public function __construct(array $argv) {
	$this->argv = $argv;

	- $this->escapingMode = self::MODE_DEFAULT;
	+ $this->escapingMode = phutil_is_windows() ? self::MODE_POWERSHELL : self::MODE_DEFAULT;

	// This makes sure we throw immediately if there are errors in the
	// parameters.
	diff --git a/src/xsprintf/__tests__/PhutilCsprintfTestCase.php b/src/xsprintf/__tests__/PhutilCsprintfTestCase.php
	--- a/src/xsprintf/__tests__/PhutilCsprintfTestCase.php
	+++ b/src/xsprintf/__tests__/PhutilCsprintfTestCase.php
	@@ -29,6 +29,8 @@
	$this->assertEqual(
	'\'#\'',
	(string)$cmd);
	+ } else {
	+ $this->assertSkipped(pht("This test doesn't work on Windows."));
	}
	}