Page MenuHomePhabricator
Files F13818070

D13576.id32812.diff
No OneTemporary
Actions

D13576.id32812.diff
View Options

diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php
--- a/src/applications/search/controller/PhabricatorApplicationSearchController.php
+++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php
@@ -185,7 +185,11 @@
$title = pht('Advanced Search');
}
- $box = new PHUIObjectBoxView();
+ $header = id(new PHUIHeaderView())
+ ->setHeader($title);
+
+ $box = id(new PHUIObjectBoxView())
+ ->setHeader($header);
if ($run_query || $named_query) {
$box->setShowHide(
@@ -227,16 +231,12 @@
$saved_query);
}
- $header = id(new PHUIHeaderView())
- ->setHeader($title);
if ($list->getActions()) {
foreach ($list->getActions() as $action) {
$header->addActionLink($action);
}
}
- $box->setHeader($header);
-
if ($list->getObjectList()) {
$box->setObjectList($list->getObjectList());
}
@@ -267,8 +267,6 @@
'This query specifies an invalid parameter. Review the '.
'query parameters and correct errors.');
}
- } else {
- $box->setHeaderText($title);
}
if ($errors) {
diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
--- a/src/view/phui/PHUIObjectBoxView.php
+++ b/src/view/phui/PHUIObjectBoxView.php
@@ -190,10 +190,10 @@
}
public function render() {
-
require_celerity_resource('phui-object-box-css');
$header = $this->header;
+
if ($this->headerText) {
$header = id(new PHUIHeaderView())
->setHeader($this->headerText);
@@ -201,6 +201,10 @@
$showhide = null;
if ($this->showAction !== null) {
+ if (!$header) {
+ $header = id(new PHUIHeaderView());
+ }
+
Javelin::initBehavior('phabricator-reveal-content');
$hide_action_id = celerity_generate_unique_node_id();

File Metadata

Mime Type
text/plain
Expires
Sat, Sep 21, 5:28 AM (22 h, 5 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6624892
Default Alt Text
D13576.id32812.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility