Page MenuHomePhabricator
Files F13812936

D8461.id20066.diff
No OneTemporary
Actions

D8461.id20066.diff
View Options

diff --git a/src/lint/linter/__tests__/ArcanistLinterTestCase.php b/src/lint/linter/__tests__/ArcanistLinterTestCase.php
--- a/src/lint/linter/__tests__/ArcanistLinterTestCase.php
+++ b/src/lint/linter/__tests__/ArcanistLinterTestCase.php
@@ -19,8 +19,7 @@
$test_count++;
}
- $this->assertEqual(
- true,
+ $this->assertTrue(
($test_count > 0),
pht('Expected to find some .lint-test tests in directory %s!', $root));
}
@@ -135,7 +134,7 @@
switch ($basename) {
default:
- $this->assertEqual(false, $caught_exception, $exception_message);
+ $this->assertEqual($caught_exception, $exception_message);
$this->compareLint($basename, $expect, $result);
$this->compareTransform($xform, $after_lint);
break;
diff --git a/src/parser/__tests__/ArcanistBundleTestCase.php b/src/parser/__tests__/ArcanistBundleTestCase.php
--- a/src/parser/__tests__/ArcanistBundleTestCase.php
+++ b/src/parser/__tests__/ArcanistBundleTestCase.php
@@ -146,8 +146,7 @@
// affected path because we don't care about the order in which the
// changes appear.
foreach ($raw_changes as $change) {
- $this->assertEqual(
- true,
+ $this->assertTrue(
empty($changes[$change->getCurrentPath()]),
"Unique Path: ".$change->getCurrentPath());
$changes[$change->getCurrentPath()] = $change;
@@ -568,7 +567,7 @@
case '228d7be4840313ed805c25c15bba0f7b188af3e6':
// "Add a text file."
// This commit is never reached because we skip the 0th commit junk.
- $this->assertEqual(true, "This is never reached.");
+ $this->assertTrue(true, "This is never reached.");
break;
default:
throw new Exception(
diff --git a/src/parser/__tests__/ArcanistDiffParserTestCase.php b/src/parser/__tests__/ArcanistDiffParserTestCase.php
--- a/src/parser/__tests__/ArcanistDiffParserTestCase.php
+++ b/src/parser/__tests__/ArcanistDiffParserTestCase.php
@@ -37,7 +37,7 @@
$this->assertEqual(count($changes), $expect_two ? 2 : 1);
$change = reset($changes);
- $this->assertEqual(true, $change !== null);
+ $this->assertTrue($change !== null);
$hunks = $change->getHunks();
$this->assertEqual(1, count($hunks));
@@ -327,8 +327,7 @@
$this->assertEqual(
$change->getCurrentPath(),
$target->getOldPath());
- $this->assertEqual(
- true,
+ $this->assertTrue(
in_array($target->getCurrentPath(), $change->getAwayPaths()));
break;
case 'git-merge-header.gitdiff':
@@ -653,8 +652,7 @@
} catch (Exception $ex) {
$caught = $ex;
}
- $this->assertEqual(
- true,
+ $this->assertTrue(
($caught instanceof Exception),
"Ambiguous: {$input}");
}
diff --git a/src/unit/engine/__tests__/XUnitTestResultParserTestCase.php b/src/unit/engine/__tests__/XUnitTestResultParserTestCase.php
--- a/src/unit/engine/__tests__/XUnitTestResultParserTestCase.php
+++ b/src/unit/engine/__tests__/XUnitTestResultParserTestCase.php
@@ -38,7 +38,7 @@
// OK
}
- $this->assertEqual(true, true);
+ $this->assertTrue(true);
}
public function testInvalidXmlInputFailure() {
@@ -53,7 +53,7 @@
// OK
}
- $this->assertEqual(true, true);
+ $this->assertTrue(true);
}
}

File Metadata

Mime Type
text/plain
Expires
Thu, Sep 19, 7:06 PM (9 m, 8 s)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6621528
Default Alt Text
D8461.id20066.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility