Page MenuHomePhabricator
Files F13331684

D8571.id20339.diff
No OneTemporary
Actions

D8571.id20339.diff
View Options

diff --git a/src/applications/people/controller/PhabricatorPeopleListController.php b/src/applications/people/controller/PhabricatorPeopleListController.php
--- a/src/applications/people/controller/PhabricatorPeopleListController.php
+++ b/src/applications/people/controller/PhabricatorPeopleListController.php
@@ -53,16 +53,14 @@
$email = pht('Unverified');
}
- $user_handle = new PhabricatorObjectHandle();
- $user_handle->setImageURI($user->loadProfileImageURI());
-
$item = new PHUIObjectItemView();
$item->setHeader($user->getFullName())
->setHref('/p/'.$user->getUsername().'/')
->addAttribute(hsprintf('%s %s',
phabricator_date($user->getDateCreated(), $viewer),
phabricator_time($user->getDateCreated(), $viewer)))
- ->addAttribute($email);
+ ->addAttribute($email)
+ ->setImageURI($user->getProfileImageURI());
if ($user->getIsDisabled()) {
$item->addIcon('disable', pht('Disabled'));
diff --git a/src/applications/people/query/PhabricatorPeopleSearchEngine.php b/src/applications/people/query/PhabricatorPeopleSearchEngine.php
--- a/src/applications/people/query/PhabricatorPeopleSearchEngine.php
+++ b/src/applications/people/query/PhabricatorPeopleSearchEngine.php
@@ -26,7 +26,8 @@
public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
$query = id(new PhabricatorPeopleQuery())
- ->needPrimaryEmail(true);
+ ->needPrimaryEmail(true)
+ ->needProfileImage(true);
$usernames = $saved->getParameter('usernames', array());
if ($usernames) {
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -32,7 +32,7 @@
protected $isEmailVerified = 0;
protected $isApproved = 0;
- private $profileImage = null;
+ private $profileImage = self::ATTACHABLE;
private $profile = null;
private $status = self::ATTACHABLE;
private $preferences = null;
@@ -647,8 +647,12 @@
return $this;
}
+ public function getProfileImageURI() {
+ return $this->assertAttached($this->profileImage);
+ }
+
public function loadProfileImageURI() {
- if ($this->profileImage) {
+ if ($this->profileImage && $this->profileImage !== self::ATTACHABLE) {
return $this->profileImage;
}
diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css
--- a/webroot/rsrc/css/phui/phui-object-item-list-view.css
+++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css
@@ -572,7 +572,7 @@
.phui-object-item-image {
width: 50px;
height: 50px;
- margin: 4px 4px 4px 8px;
+ margin: 4px 4px 4px 4px;
position: absolute;
background-color: {$lightbluebackground};
}
@@ -582,5 +582,5 @@
}
.phui-object-item-with-image .phui-object-item-content-box {
- margin-left: 58px;
+ margin-left: 54px;
}

File Metadata

Mime Type
text/plain
Expires
Tue, Jun 18, 7:24 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6295557
Default Alt Text
D8571.id20339.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility