Page MenuHomePhabricator

D9473.diff
No OneTemporary

D9473.diff

diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php
--- a/src/lint/linter/ArcanistPEP8Linter.php
+++ b/src/lint/linter/ArcanistPEP8Linter.php
@@ -109,12 +109,7 @@
if (preg_match('/^W/', $code)) {
return ArcanistLintSeverity::SEVERITY_WARNING;
} else {
-
- // TODO: Once severities/.arclint are more usable, restore this to
- // "ERROR".
- // return ArcanistLintSeverity::SEVERITY_ERROR;
-
- return ArcanistLintSeverity::SEVERITY_WARNING;
+ return ArcanistLintSeverity::SEVERITY_ERROR;
}
}
diff --git a/src/lint/linter/__tests__/pep8/imports.lint-test b/src/lint/linter/__tests__/pep8/imports.lint-test
--- a/src/lint/linter/__tests__/pep8/imports.lint-test
+++ b/src/lint/linter/__tests__/pep8/imports.lint-test
@@ -1,3 +1,3 @@
import os, sys
~~~~~~~~~~
-warning:1:10
+error:1:10

File Metadata

Mime Type
text/plain
Expires
Wed, Jun 5, 6:44 AM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6299689
Default Alt Text
D9473.diff (876 B)

Event Timeline