Page MenuHomePhabricator
Files F13282137

D18058.diff
No OneTemporary
Actions

D18058.diff
View Options

diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php
--- a/src/applications/maniphest/storage/ManiphestTransaction.php
+++ b/src/applications/maniphest/storage/ManiphestTransaction.php
@@ -40,6 +40,22 @@
return parent::shouldGenerateOldValue();
}
+ public function shouldHideForFeed() {
+ // NOTE: Modular transactions don't currently support this, and it has
+ // very few callsites, and it's publish-time rather than display-time.
+ // This should probably become a supported, display-time behavior. For
+ // discussion, see T12787.
+
+ // Hide "alice created X, a task blocking Y." from feed because it
+ // will almost always appear adjacent to "alice created Y".
+ $is_new = $this->getMetadataValue('blocker.new');
+ if ($is_new) {
+ return true;
+ }
+
+ return parent::shouldHideForFeed();
+ }
+
public function getRequiredHandlePHIDs() {
$phids = parent::getRequiredHandlePHIDs();
diff --git a/src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php
--- a/src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php
+++ b/src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php
@@ -9,15 +9,6 @@
return null;
}
- public function shouldHideForFeed() {
- // Hide "alice created X, a task blocking Y." from feed because it
- // will almost always appear adjacent to "alice created Y".
- $is_new = $this->getMetadataValue('blocker.new');
- if ($is_new) {
- return true;
- }
- }
-
public function getActionName() {
$old = $this->getOldValue();
$new = $this->getNewValue();

File Metadata

Mime Type
text/plain
Expires
Mon, Jun 3, 11:44 AM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6289290
Default Alt Text
D18058.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility