D8899.diff
No OneTemporary
Actions

Size

980 B

Referenced Files

None

Subscribers

None

D8899.diff
View Options

	diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	@@ -451,6 +451,15 @@
	switch ($this->getTransactionType()) {
	case PhabricatorTransactions::TYPE_TOKEN:
	return true;
	+ case PhabricatorTransactions::TYPE_BUILDABLE:
	+ switch ($this->getNewValue()) {
	+ case HarbormasterBuildable::STATUS_PASSED:
	+ // For now, don't notify on build passes either. These are pretty
	+ // high volume and annoying, with very little present value. We
	+ // might want to turn them back on in the specific case of
	+ // build successes on the current document?
	+ return true;
	+ }
	}

	return $this->shouldHide();