Files F13245281

D21487.diff
No OneTemporary
Actions

Size

840 B

Referenced Files

None

Subscribers

None

D21487.diff
View Options

	diff --git a/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php b/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
	--- a/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
	+++ b/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
	@@ -181,6 +181,12 @@
	$normal_password = phutil_utf8_strtolower($raw_password);
	if (strlen($normal_password) >= $minimum_similarity) {
	foreach ($normal_map as $term => $source) {
	+
	+ // See T2312. This may be required if the term list includes numeric
	+ // strings like "12345", which will be cast to integers when used as
	+ // array keys.
	+ $term = phutil_string_cast($term);
	+
	if (strpos($term, $normal_password) === false &&
	strpos($normal_password, $term) === false) {
	continue;

File Metadata

Mime Type: text/plain
Expires: Fri, May 24, 5:54 AM (3 w, 3 d ago)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 6276633
Default Alt Text: D21487.diff (840 B)

Event Timeline