D14519.id.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D14519.id.diff
View Options

	diff --git a/src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php b/src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php
	--- a/src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php
	+++ b/src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php
	@@ -295,9 +295,6 @@
	// NOTE: This is only "use x;", in anonymous functions the node type is
	// n_LEXICAL_VARIABLE_LIST even though both tokens are T_USE.

	- // TODO: We parse n_USE in a slightly crazy way right now; that would be
	- // a better selector once it's fixed.
	-
	$uses = $root->selectDescendantsOfType('n_USE_LIST');
	foreach ($uses as $use) {
	$this->raiseLintAtNode(
	diff --git a/src/lint/linter/xhpast/rules/__tests__/php-compatibility/php53-features.lint-test b/src/lint/linter/xhpast/rules/__tests__/php-compatibility/php53-features.lint-test
	--- a/src/lint/linter/xhpast/rules/__tests__/php-compatibility/php53-features.lint-test
	+++ b/src/lint/linter/xhpast/rules/__tests__/php-compatibility/php53-features.lint-test
	@@ -12,7 +12,7 @@
	echo __DIR__;
	~~~~~~~~~~
	error:3:1
	-error:4:5
	+error:4:1
	error:5:3
	error:6:3
	error:7:1