Page MenuHomePhabricator
Files F13226747

D20784.diff
No OneTemporary
Actions

D20784.diff
View Options

diff --git a/src/infrastructure/cluster/PhabricatorDatabaseRef.php b/src/infrastructure/cluster/PhabricatorDatabaseRef.php
--- a/src/infrastructure/cluster/PhabricatorDatabaseRef.php
+++ b/src/infrastructure/cluster/PhabricatorDatabaseRef.php
@@ -221,6 +221,9 @@
return $this->replicaRefs;
}
+ public function getDisplayName() {
+ return $this->getRefKey();
+ }
public function getRefKey() {
$host = $this->getHost();
diff --git a/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php b/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php
--- a/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php
+++ b/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php
@@ -89,6 +89,10 @@
return $this->namespace.'_'.$fragment;
}
+ public function getDisplayName() {
+ return $this->getRef()->getDisplayName();
+ }
+
public function getDatabaseList(array $patches, $only_living = false) {
assert_instances_of($patches, 'PhabricatorStoragePatch');
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php
@@ -21,86 +21,112 @@
}
public function didExecute(PhutilArgumentParser $args) {
- $console = PhutilConsole::getConsole();
+ $api = $this->getSingleAPI();
+
+ $host_display = $api->getDisplayName();
if (!$this->isDryRun() && !$this->isForce()) {
if ($args->getArg('unittest-fixtures')) {
- $console->writeOut(
- phutil_console_wrap(
- pht(
- 'Are you completely sure you really want to destroy all unit '.
- 'test fixure data? This operation can not be undone.')));
+ $warning = pht(
+ 'Are you completely sure you really want to destroy all unit '.
+ 'test fixure data on host "%s"? This operation can not be undone.',
+ $host_display);
+
+ echo tsprintf(
+ '%B',
+ id(new PhutilConsoleBlock())
+ ->addParagraph($warning)
+ ->drawConsoleString());
+
if (!phutil_console_confirm(pht('Destroy all unit test data?'))) {
- $console->writeOut("%s\n", pht('Cancelled.'));
+ $this->logFail(
+ pht('CANCELLED'),
+ pht('User cancelled operation.'));
exit(1);
}
} else {
- $console->writeOut(
- phutil_console_wrap(
- pht(
- 'Are you completely sure you really want to permanently destroy '.
- 'all storage for Phabricator data? This operation can not be '.
- 'undone and your data will not be recoverable if you proceed.')));
+ $warning = pht(
+ 'Are you completely sure you really want to permanently destroy '.
+ 'all storage for Phabricator data on host "%s"? This operation '.
+ 'can not be undone and your data will not be recoverable if '.
+ 'you proceed.',
+ $host_display);
+
+ echo tsprintf(
+ '%B',
+ id(new PhutilConsoleBlock())
+ ->addParagraph($warning)
+ ->drawConsoleString());
if (!phutil_console_confirm(pht('Permanently destroy all data?'))) {
- $console->writeOut("%s\n", pht('Cancelled.'));
+ $this->logFail(
+ pht('CANCELLED'),
+ pht('User cancelled operation.'));
exit(1);
}
if (!phutil_console_confirm(pht('Really destroy all data forever?'))) {
- $console->writeOut("%s\n", pht('Cancelled.'));
+ $this->logFail(
+ pht('CANCELLED'),
+ pht('User cancelled operation.'));
exit(1);
}
}
}
- $apis = $this->getMasterAPIs();
- foreach ($apis as $api) {
- $patches = $this->getPatches();
+ $patches = $this->getPatches();
- if ($args->getArg('unittest-fixtures')) {
- $conn = $api->getConn(null);
- $databases = queryfx_all(
- $conn,
- 'SELECT DISTINCT(TABLE_SCHEMA) AS db '.
- 'FROM INFORMATION_SCHEMA.TABLES '.
- 'WHERE TABLE_SCHEMA LIKE %>',
- PhabricatorTestCase::NAMESPACE_PREFIX);
- $databases = ipull($databases, 'db');
- } else {
- $databases = $api->getDatabaseList($patches);
- $databases[] = $api->getDatabaseName('meta_data');
+ if ($args->getArg('unittest-fixtures')) {
+ $conn = $api->getConn(null);
+ $databases = queryfx_all(
+ $conn,
+ 'SELECT DISTINCT(TABLE_SCHEMA) AS db '.
+ 'FROM INFORMATION_SCHEMA.TABLES '.
+ 'WHERE TABLE_SCHEMA LIKE %>',
+ PhabricatorTestCase::NAMESPACE_PREFIX);
+ $databases = ipull($databases, 'db');
+ } else {
+ $databases = $api->getDatabaseList($patches);
+ $databases[] = $api->getDatabaseName('meta_data');
- // These are legacy databases that were dropped long ago. See T2237.
- $databases[] = $api->getDatabaseName('phid');
- $databases[] = $api->getDatabaseName('directory');
- }
+ // These are legacy databases that were dropped long ago. See T2237.
+ $databases[] = $api->getDatabaseName('phid');
+ $databases[] = $api->getDatabaseName('directory');
+ }
- foreach ($databases as $database) {
- if ($this->isDryRun()) {
- $console->writeOut(
- "%s\n",
- pht("DRYRUN: Would drop database '%s'.", $database));
- } else {
- $console->writeOut(
- "%s\n",
- pht("Dropping database '%s'...", $database));
- queryfx(
- $api->getConn(null),
- 'DROP DATABASE IF EXISTS %T',
- $database);
- }
- }
+ asort($databases);
- if (!$this->isDryRun()) {
- $console->writeOut(
- "%s\n",
+ foreach ($databases as $database) {
+ if ($this->isDryRun()) {
+ $this->logInfo(
+ pht('DRY RUN'),
+ pht(
+ 'Would drop database "%s" on host "%s".',
+ $database,
+ $host_display));
+ } else {
+ $this->logWarn(
+ pht('DESTROY'),
pht(
- 'Storage on "%s" was destroyed.',
- $api->getRef()->getRefKey()));
+ 'Dropping database "%s" on host "%s"...',
+ $database,
+ $host_display));
+
+ queryfx(
+ $api->getConn(null),
+ 'DROP DATABASE IF EXISTS %T',
+ $database);
}
}
+ if (!$this->isDryRun()) {
+ $this->logOkay(
+ pht('DONE'),
+ pht(
+ 'Storage on "%s" was destroyed.',
+ $host_display));
+ }
+
return 0;
}

File Metadata

Mime Type
text/plain
Expires
Mon, May 20, 11:06 PM (3 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6276832
Default Alt Text
D20784.diff (6 KB)

Event Timeline

Phabricator · Built by Phacility