Page MenuHomePhabricator
Files F13225846

D19587.id46847.diff
No OneTemporary
Actions

D19587.id46847.diff
View Options

diff --git a/src/applications/diffusion/controller/DiffusionBlameController.php b/src/applications/diffusion/controller/DiffusionBlameController.php
--- a/src/applications/diffusion/controller/DiffusionBlameController.php
+++ b/src/applications/diffusion/controller/DiffusionBlameController.php
@@ -24,6 +24,7 @@
->setViewer($viewer)
->withRepository($repository)
->withIdentifiers($identifiers)
+ ->needIdentities(true)
->execute();
$commits = mpull($commits, null, 'getCommitIdentifier');
} else {
@@ -68,10 +69,7 @@
$handle_phids = array();
foreach ($commits as $commit) {
- $author_phid = $commit->getAuthorPHID();
- if ($author_phid) {
- $handle_phids[] = $author_phid;
- }
+ $handle_phids[] = $commit->getAuthorDisplayPHID();
}
foreach ($revisions as $revision) {
@@ -117,11 +115,7 @@
$author_phid = null;
if ($commit) {
- $author_phid = $commit->getAuthorPHID();
- }
-
- if (!$author_phid && $revision) {
- $author_phid = $revision->getAuthorPHID();
+ $author_phid = $commit->getAuthorDisplayPHID();
}
if (!$author_phid) {
diff --git a/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php b/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
--- a/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
+++ b/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
@@ -30,6 +30,7 @@
array $handles,
array $objects) {
+ $avatar_uri = celerity_get_resource_uri('/rsrc/image/avatar.png');
foreach ($handles as $phid => $handle) {
$identity = $objects[$phid];
@@ -39,6 +40,8 @@
$handle->setObjectName(pht('Identity %d', $id));
$handle->setName($name);
$handle->setURI($identity->getURI());
+ $handle->setIcon('fa-user');
+ $handle->setImageURI($avatar_uri);
}
}

File Metadata

Mime Type
text/plain
Expires
Mon, May 20, 5:45 PM (3 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6303958
Default Alt Text
D19587.id46847.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility