Page MenuHomePhabricator
Files F13213293

D15823.diff
No OneTemporary
Actions

D15823.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => '04a95108',
+ 'core.pkg.css' => 'ede6bf7a',
'core.pkg.js' => '6972d365',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '7ba78475',
@@ -136,7 +136,7 @@
'rsrc/css/phui/phui-form-view.css' => '6a51768e',
'rsrc/css/phui/phui-form.css' => 'aac1d51d',
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
- 'rsrc/css/phui/phui-header-view.css' => '230254d3',
+ 'rsrc/css/phui/phui-header-view.css' => '9961e480',
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
'rsrc/css/phui/phui-icon.css' => '3f33ab57',
@@ -829,7 +829,7 @@
'phui-form-css' => 'aac1d51d',
'phui-form-view-css' => '6a51768e',
'phui-head-thing-view-css' => 'fd311e5f',
- 'phui-header-view-css' => '230254d3',
+ 'phui-header-view-css' => '9961e480',
'phui-hovercard' => '1bd28176',
'phui-hovercard-view-css' => 'de1a2119',
'phui-icon-set-selector-css' => '1ab67aad',
diff --git a/src/view/phui/PHUIHeaderView.php b/src/view/phui/PHUIHeaderView.php
--- a/src/view/phui/PHUIHeaderView.php
+++ b/src/view/phui/PHUIHeaderView.php
@@ -316,6 +316,15 @@
$header_content);
}
+ // This wrapper element allows titles to be triple-clicked to select them
+ // in Firefox. See T10905 for discussion.
+ $header_content = phutil_tag(
+ 'span',
+ array(
+ 'class' => 'phui-header-content',
+ ),
+ $header_content);
+
$left[] = phutil_tag(
'span',
array(
diff --git a/webroot/rsrc/css/phui/phui-header-view.css b/webroot/rsrc/css/phui/phui-header-view.css
--- a/webroot/rsrc/css/phui/phui-header-view.css
+++ b/webroot/rsrc/css/phui/phui-header-view.css
@@ -80,6 +80,10 @@
color: {$lightbluetext};
}
+.phui-header-content {
+ display: inline-block;
+}
+
.phui-object-box .phui-header-tall .phui-header-header,
.phui-document-view .phui-header-tall .phui-header-header {
font-size: 18px;

File Metadata

Mime Type
text/plain
Expires
Sat, May 18, 7:35 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6299875
Default Alt Text
D15823.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility