Page MenuHomePhabricator

D17983.id43242.diff
No OneTemporary

D17983.id43242.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -13,7 +13,7 @@
'core.pkg.js' => 'e822b496',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '4d7dd14e',
- 'differential.pkg.js' => '6d05ad4c',
+ 'differential.pkg.js' => '73f63b79',
'diffusion.pkg.css' => 'b93d9b8c',
'diffusion.pkg.js' => '84c8f8fd',
'favicon.ico' => '30672e08',
@@ -394,7 +394,7 @@
'rsrc/js/application/diff/DiffChangesetList.js' => '541206ba',
'rsrc/js/application/diff/DiffInline.js' => '77e14b60',
'rsrc/js/application/diff/ScrollObjective.js' => '0eee7a00',
- 'rsrc/js/application/diff/ScrollObjectiveList.js' => '1ca4d9db',
+ 'rsrc/js/application/diff/ScrollObjectiveList.js' => '8cd43b1c',
'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
'rsrc/js/application/differential/behavior-comment-preview.js' => '51c5ad07',
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
@@ -800,7 +800,7 @@
'phabricator-prefab' => 'c5af80a2',
'phabricator-remarkup-css' => 'd1a5e11e',
'phabricator-scroll-objective' => '0eee7a00',
- 'phabricator-scroll-objective-list' => '1ca4d9db',
+ 'phabricator-scroll-objective-list' => '8cd43b1c',
'phabricator-search-results-css' => 'f87d23ad',
'phabricator-shaped-request' => '7cbe244b',
'phabricator-slowvote-css' => 'a94b7230',
@@ -1034,14 +1034,6 @@
'javelin-request',
'javelin-uri',
),
- '1ca4d9db' => array(
- 'javelin-dom',
- 'javelin-util',
- 'javelin-stratcom',
- 'javelin-install',
- 'javelin-workflow',
- 'phabricator-scroll-objective',
- ),
'1def2711' => array(
'javelin-install',
'javelin-dom',
@@ -1588,6 +1580,14 @@
'javelin-install',
'javelin-dom',
),
+ '8cd43b1c' => array(
+ 'javelin-dom',
+ 'javelin-util',
+ 'javelin-stratcom',
+ 'javelin-install',
+ 'javelin-workflow',
+ 'phabricator-scroll-objective',
+ ),
'8ce821c5' => array(
'phabricator-notification',
'javelin-stratcom',
diff --git a/webroot/rsrc/js/application/diff/ScrollObjectiveList.js b/webroot/rsrc/js/application/diff/ScrollObjectiveList.js
--- a/webroot/rsrc/js/application/diff/ScrollObjectiveList.js
+++ b/webroot/rsrc/js/application/diff/ScrollObjectiveList.js
@@ -74,6 +74,9 @@
(JX.Device.getDevice() == 'desktop') &&
(this._objectives.length);
+ // Disable this element unconditionally. See D17955.
+ is_visible = false;
+
if (!is_visible) {
JX.DOM.remove(node);
return;

File Metadata

Mime Type
text/plain
Expires
Sat, May 18, 1:30 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6274540
Default Alt Text
D17983.id43242.diff (2 KB)

Event Timeline