D10743.diff
No OneTemporary
Actions

Size

654 B

Referenced Files

None

Subscribers

None

D10743.diff
View Options

	diff --git a/src/console/format.php b/src/console/format.php
	--- a/src/console/format.php
	+++ b/src/console/format.php
	@@ -37,7 +37,9 @@
	throw $ex;
	}

	- $use_history = true;
	+ // `escapeshellarg` makes double quotes in the command below disappear on
	+ // Windows, which breaks prompts when using history. See T6348
	+ $use_history = !phutil_is_windows();
	if ($history == '') {
	$use_history = false;
	} else {
	@@ -45,8 +47,6 @@
	list($err) = exec_manual('bash -c %s', 'true');
	if ($err) {
	$use_history = false;
	- } else if (phutil_is_windows()) {
	- $history = str_replace('\\', '/', $history);
	}
	}