Page MenuHomePhabricator

D19725.id47142.diff
No OneTemporary

D19725.id47142.diff

diff --git a/src/xsprintf/PhutilTerminalString.php b/src/xsprintf/PhutilTerminalString.php
--- a/src/xsprintf/PhutilTerminalString.php
+++ b/src/xsprintf/PhutilTerminalString.php
@@ -70,6 +70,13 @@
$value = preg_replace('/\r(?!\n)/', '<CR>', $value);
}
+ // See T13209. If we print certain invalid unicode byte sequences to the
+ // terminal under "cmd.exe", the entire string is silently dropped. Avoid
+ // printing invalid sequences.
+ if (phutil_is_windows()) {
+ $value = phutil_utf8ize($value);
+ }
+
return $value;
}
}

File Metadata

Mime Type
text/plain
Expires
Fri, May 17, 9:59 PM (2 w, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6276590
Default Alt Text
D19725.id47142.diff (570 B)

Event Timeline