Page MenuHomePhabricator
Files F13204812

D18415.diff
No OneTemporary
Actions

D18415.diff
View Options

diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php
--- a/src/applications/differential/storage/DifferentialRevision.php
+++ b/src/applications/differential/storage/DifferentialRevision.php
@@ -72,7 +72,7 @@
->attachRepository(null)
->attachActiveDiff(null)
->attachReviewers(array())
- ->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
+ ->setModernRevisionStatus(DifferentialRevisionStatus::NEEDS_REVIEW);
}
protected function getConfiguration() {
diff --git a/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php b/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php
@@ -47,7 +47,8 @@
}
public function applyInternalEffects($object, $value) {
- $object->setStatus(ArcanistDifferentialRevisionStatus::ABANDONED);
+ $status_abandoned = DifferentialRevisionStatus::ABANDONED;
+ $object->setModernRevisionStatus($status_abandoned);
}
protected function validateAction($object, PhabricatorUser $viewer) {
diff --git a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
@@ -37,8 +37,8 @@
public function applyInternalEffects($object, $value) {
$was_accepted = $object->isAccepted();
- $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
- $object->setStatus($status_closed);
+ $status_published = DifferentialRevisionStatus::PUBLISHED;
+ $object->setModernRevisionStatus($status_published);
$object->setProperty(
DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED,
diff --git a/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php b/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
@@ -50,8 +50,8 @@
}
public function applyInternalEffects($object, $value) {
- $status_planned = ArcanistDifferentialRevisionStatus::CHANGES_PLANNED;
- $object->setStatus($status_planned);
+ $status_planned = DifferentialRevisionStatus::CHANGES_PLANNED;
+ $object->setModernRevisionStatus($status_planned);
}
protected function validateAction($object, PhabricatorUser $viewer) {
diff --git a/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php b/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
@@ -47,7 +47,8 @@
}
public function applyInternalEffects($object, $value) {
- $object->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
+ $status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
+ $object->setModernRevisionStatus($status_review);
}
protected function validateAction($object, PhabricatorUser $viewer) {
diff --git a/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php b/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
@@ -35,7 +35,8 @@
}
public function applyInternalEffects($object, $value) {
- $object->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
+ $status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
+ $object->setModernRevisionStatus($status_review);
}
protected function validateAction($object, PhabricatorUser $viewer) {
diff --git a/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php b/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
@@ -31,8 +31,8 @@
}
public function applyInternalEffects($object, $value) {
- $status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;
- $object->setStatus($status_review);
+ $status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
+ $object->setModernRevisionStatus($status_review);
}
protected function validateAction($object, PhabricatorUser $viewer) {

File Metadata

Mime Type
text/plain
Expires
Thu, May 16, 1:09 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6289383
Default Alt Text
D18415.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility